-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue712 service deployment 2 #724
Conversation
Cleanup exisiting bash scripts For tags no longer using "-service" and just using the boptest tag name for both boptest library and the web and worker images.
Merging PR to development branch for further testing
@tijcolem Sorry for the various PRs, but I opened this new one to test publishing of the images using a new branch "develop." It looks like upon merging, the new images were published ok? See /~https://github.com/orgs/ibpsa/packages and /~https://github.com/ibpsa/project1-boptest/actions/runs/12776057731/job/35613840779. Now, if those look good, I'm realizing from what you said here "we're good to tag", I wanted to point out that v0.7.0 has already been tagged when we released it in November, and there's been development on the master since that I don't want included in the deployed images if they are to be with reference to v0.7.0. I'm thinking my options are to either create a new interim tag 0.7.1 and we use those images, or cherry pick your commits that implement the github action to a new branch (maybe "experimental") off of the 0.7.0 tag commit. But then, I suppose the referenced branch name on the image tag won't be correct. Do you agree that a new tag 0.7.1 is the best approach here, or other thoughts? |
@dhblum I'm not seeing the packages on /~https://github.com/orgs/ibpsa/packages It's possible you need to change the visibility to for those. Since you already tagged 0.7.0, a 0.7.1 makes sense in this case. |
Cool, I think we'll need to ask to change it to public. It's the k8s manager that will be requesting these images and that lives within AWS. If your org doesn't want to make them public, we can change the k8s to include a user/pass/token to access these images. These were historically made public in the docker hub NREL registry. |
Ok thanks. Let me check in with the organization admin. |
@tijcolem The administrator changed permissions to allow public packages and I've made both of the packages, web and worker, public. Please take a look again and let me know if you can access them and test their deployment. Let me know anything else to do, otherwise I will prepare a 0.7.1 release to generate tagged images. |
@dhblum Great! I can pull the images now. All looks good to tag and release the 0.7.1. |
For #712 in place of #723.