Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added test cases to test support for boolean exps in select statements" (backport #7194) [release/4.9.x] #7197

Merged
merged 3 commits into from
Sep 25, 2024
+30 −31
Merged

Revert "Added test cases to test support for boolean exps in select statements" (backport #7194) [release/4.9.x] #7197

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ce467d
Revert "Added test cases to test support for boolean exps in select s…
soham-bentley Sep 25, 2024
8eccaac
native@4.9.29
aruniverse Sep 25, 2024
95724f8
rush change
aruniverse Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...n/changes/@itwin/core-backend/revert-7150-Soham-booleanExpsInSelect_2024-09-25-06-10.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@itwin/core-backend",
"comment": "Removed added tests for boolean exps in select statement",
"type": "none"
}
],
"packageName": "@itwin/core-backend"
}
20 changes: 0 additions & 20 deletions core/backend/src/test/ecdb/ECSqlAst.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,26 +475,6 @@ describe("ECSql Abstract Syntax Tree", () => {
assert.equal(test.expectedECSql, await toNormalizeECSql(test.expectedECSql));
}
});
it("parse Boolean Exp in Select statements", async () => {
const tests = [
{
orignalECSql: "select 1 < true",
expectedECSql: "SELECT (1 < TRUE)",
},
{
orignalECSql: "select 2 IN(2,7)",
expectedECSql: "SELECT 2 IN (2, 7)",
},
{
orignalECSql: "SELECT p.ECInstanceId=k.s FROM meta.ECClassDef p, (SELECT 1 s) k",
expectedECSql: "SELECT ([p].[ECInstanceId] = [k].[s]) FROM [ECDbMeta].[ECClassDef] [p], (SELECT 1 [s]) [k]",
},
];
for (const test of tests) {
assert.equal(test.expectedECSql, await toNormalizeECSql(test.orignalECSql));
assert.equal(test.expectedECSql, await toNormalizeECSql(test.expectedECSql));
}
});
it("parse $, $->prop", async () => {
const tests = [
{
Expand Down
Loading