Presentation: Enforce result paging for hierarchy compare #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconne
reviewed
Jan 29, 2021
grigasp
requested changes
Feb 1, 2021
presentation/common/src/presentation-common/PresentationManagerOptions.ts
Outdated
Show resolved
Hide resolved
presentation/common/src/presentation-common/PresentationRpcInterface.ts
Outdated
Show resolved
Hide resolved
presentation/frontend/src/presentation-frontend/PresentationManager.ts
Outdated
Show resolved
Hide resolved
grigasp
requested changes
Feb 1, 2021
presentation/common/src/presentation-common/PresentationRpcInterface.ts
Outdated
Show resolved
Hide resolved
pmconne
approved these changes
Feb 1, 2021
grigasp
approved these changes
Feb 1, 2021
kabentley
added a commit
that referenced
this pull request
Feb 11, 2021
* Presentation: Enable an option for presentation backend to use memory mapped i/o for worker SQLite connections (#690) * presentation/default units (#657) * Add default-units functionality and testing * change and API * PR Fixes * PR fixes * renaming * PR fix * style fix * PR fixes * NextVersion and minor fixes * PR fixes * minor fix * PR fixes * minor fix * Presentation: Enforce result paging for hierarchy compare (#678) * Enforce hierarchy compare result paging * extract-api * rush change * Restore broken public api * rush extract-api * Rename to 'continuationToken' * Add test for hierarchy compare paging * Update RPC version * Adjustments to latest ECDb changes for moving properties (#730) * rework IModelApp and IModelHost initialization (#687) * add ipc response handler * use responseHandler for NativeApp * extract-api * split out TxnManager * extract-api, again * remove EventSink and EventSource * wip * wip * get tests working * ElectronHost and ElectronApp * clean up startup code * clean up documenation * work on mobile-manager * wip * add mobile-manager * IOSApp and AndroidApp * directory case change * wip * wip * lint cleanup * use Ipc for StandaloneConnection * clean up documentation * rename callBackend to callXxxHost * clear subcategories in beforeClose rather than in each subclass * deprecate RemoteBriefcaseConnection, added RemoteIModelConnection * extract-api * rename RemoteIModelConnection to CheckpointConnection * more documentation * always import IModelStatus from bentleyjs-core in backend * fix presentation-backend test failures * Get presentation update-related tests working again * Update docs/learning/backend/IModelHost.md Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * Update core/common/tsconfig.json Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> * add ProcessDetector * extract-api * make StandaloneConnection subclass of BriefcaseConnection * use IModelDb rather than BriefcaseDb for IModelWriteRpc * Working mockmobile tests * restore mobileeventloop * restored previous mobile ipc fix * eliminate StandaloneConnection class * fix openStandalone test * remove naked require('electron') in favor of ElectronHost.electron * fix for restarting IModelApp in InteractiveEditingSession.test * fix interactiveEditingSession test * fix IModelVersion interface * fix lint errors * steps toward getting mobile app working...still an issue in oidc * typo...authInit being called now. just need a MobileHost.device now, I think * move websocket ipc to mobilehost...still need to port device over * IOSDevice back in action. App launches...but no tiles??? * rework IOSHost.startup * typo * documentation for TxnManager * fix lint errors * rename StandaloneConnection test to OpenStandalone * ios/mobile refactoring * api * add test for classNameToId and classIdToName * NextVersion.md * typo Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: swbsi <69857376+swbsi@users.noreply.github.com> * lint * extract-api * merge * lint errors * documenation descriptions * doc errors * documentation cleanup * revert ecschema-metadata changes Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com> Co-authored-by: aurislt7 <30312645+aurislt7@users.noreply.github.com> Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com> Co-authored-by: Robert Schili <rschili@users.noreply.github.com> Co-authored-by: kabentley <33296803+kabentley@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: swbsi <69857376+swbsi@users.noreply.github.com> Co-authored-by: Caleb Shafer <31107829+calebmshafer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compareHierarchiesrequest.compareHierarchiesreturn type to includenextStepproperty. Value of this property is defined if hierarchy comparison was interrupted because max result set size was reached and it describes position from which hierarchy comparison should be continued to get the rest of results.compareHierarchiesresult set size to avoid returning massive result sets in single request.