-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Futureon briefcase #658
Merged
Merged
Futureon briefcase #658
Changes from 9 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
a1c8fe6
edit bridgerunner to retrieve briefcaseId from prdss
admccarthy1 9322316
use argsJson for briefcaseId
admccarthy1 55cc4bb
fix error by replacing curly brace that got deleted
admccarthy1 20d10b8
fix formatting
admccarthy1 f4ef12d
return briefcaseId from synchronize
admccarthy1 07c7c81
correct formatting
admccarthy1 c0ea71a
return briefcaseId by setting argument
admccarthy1 6aa0798
cleanup
admccarthy1 a13e94a
fix undefined object errors
admccarthy1 cce3f20
Merge remote-tracking branch 'origin/master' into futureonBriefcase
admccarthy1 f4ad588
Merge branch 'master' into futureonBriefcase
mergify[bot] 6f3bc4d
do rush change
admccarthy1 a093272
Merge branch 'futureonBriefcase' of /~https://github.com/imodeljs/imode…
admccarthy1 1393e88
fix formatting
admccarthy1 c3bdf85
Merge branch 'master' into futureonBriefcase
mergify[bot] 3fa9016
Merge branch 'master' into futureonBriefcase
mergify[bot] 2deb6a9
use camelcase to fix linting errors in build
admccarthy1 a14a210
Merge branch 'futureonBriefcase' of /~https://github.com/imodeljs/imode…
admccarthy1 c673530
Merge branch 'master' into futureonBriefcase
mergify[bot] 5074af4
change to not overwrite arguments if something other than briefcaseId is
admccarthy1 cf39d7b
Merge branch 'futureonBriefcase' of /~https://github.com/imodeljs/imode…
admccarthy1 1f071eb
Merge branch 'master' into futureonBriefcase
mergify[bot] 2831afc
Merge branch 'master' into futureonBriefcase
mergify[bot] 2405bf2
Merge branch 'master' into futureonBriefcase
mergify[bot] a72b983
Merge branch 'master' into futureonBriefcase
mergify[bot] 170564b
Merge branch 'master' into futureonBriefcase
mergify[bot] 9902a00
Merge branch 'master' into futureonBriefcase
mergify[bot] b508369
Merge branch 'master' into futureonBriefcase
mergify[bot] 225bf81
Merge branch 'master' into futureonBriefcase
mergify[bot] 9f1f60d
Merge branch 'master' into futureonBriefcase
mergify[bot] 30ad730
Merge branch 'master' into futureonBriefcase
mergify[bot] 88ef09d
Merge branch 'master' into futureonBriefcase
mergify[bot] 309e5fc
Merge branch 'master' into futureonBriefcase
mergify[bot] 41a89da
Merge branch 'master' into futureonBriefcase
mergify[bot] 81d4c07
Merge branch 'master' into futureonBriefcase
mergify[bot] e621275
Merge branch 'master' into futureonBriefcase
mergify[bot] 61c7837
Merge branch 'master' into futureonBriefcase
mergify[bot] 5397735
Merge branch 'master' into futureonBriefcase
mergify[bot] 7ae4e6e
Merge branch 'master' into futureonBriefcase
mergify[bot] 2d7e5c7
Merge branch 'master' into futureonBriefcase
mergify[bot] 717dbfe
Merge branch 'master' into futureonBriefcase
mergify[bot] afa20f9
Merge branch 'master' into futureonBriefcase
mergify[bot] 6e86700
Merge branch 'master' into futureonBriefcase
mergify[bot] 5aa690c
Merge branch 'master' into futureonBriefcase
mergify[bot] 0037547
Merge branch 'master' into futureonBriefcase
mergify[bot] c68259e
Merge branch 'master' into futureonBriefcase
mergify[bot] e809a60
formatting change for linter
admccarthy1 b1ee765
Merge branch 'futureonBriefcase' of /~https://github.com/imodeljs/imode…
admccarthy1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this overwrite the additional parameters passed in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing it back in there is how we're returning the id so we can save the value to the settings service in the wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you instead do 'this._bridgeArgs.argsJson.BriefcaseId = props.briefcaseId' which preserves anything else previously set, and adds the id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had that but when i tested it I got an error because argsJson was undefined when I didn't pass anything in, I could null check it and only do it this way when its null and otherwise do it that way if we think thats better