Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presentation/default units #657

Merged
merged 14 commits into from
Feb 5, 2021

Conversation

aurislt7
Copy link
Contributor

@aurislt7 aurislt7 requested review from a team as code owners January 26, 2021 13:55
Copy link
Member

@grigasp grigasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks like code coverage of presentation-backend should be less than 100%
  • Please add a topic to NextVersion.md with an example for how to set up default format for some phenomenon/unit system.

common/api/presentation-backend.api.md Outdated Show resolved Hide resolved
docs/changehistory/NextVersion.md Outdated Show resolved Hide resolved
@grigasp grigasp merged commit 4801756 into iTwin:imodel02 Feb 5, 2021
@aurislt7 aurislt7 deleted the presentation/default-units branch February 5, 2021 11:01
kabentley added a commit that referenced this pull request Feb 11, 2021
* Presentation: Enable an option for presentation backend to use memory mapped i/o for worker SQLite connections (#690)

* presentation/default units (#657)

* Add default-units functionality and testing

* change and API

* PR Fixes

* PR fixes

* renaming

* PR fix

* style fix

* PR fixes

* NextVersion and minor fixes

* PR fixes

* minor fix

* PR fixes

* minor fix

* Presentation: Enforce result paging for hierarchy compare (#678)

* Enforce hierarchy compare result paging

* extract-api

* rush change

* Restore broken public api

* rush extract-api

* Rename to 'continuationToken'

* Add test for hierarchy compare paging

* Update RPC version

* Adjustments to latest ECDb changes for moving properties (#730)

* rework IModelApp and IModelHost initialization (#687)

* add ipc response handler

* use responseHandler for NativeApp

* extract-api

* split out TxnManager

* extract-api, again

* remove EventSink and EventSource

* wip

* wip

* get tests working

* ElectronHost and ElectronApp

* clean up startup code

* clean up documenation

* work on mobile-manager

* wip

* add mobile-manager

* IOSApp and AndroidApp

* directory case change

* wip

* wip

* lint cleanup

* use Ipc for StandaloneConnection

* clean up documentation

* rename callBackend to callXxxHost

* clear subcategories in beforeClose rather than in each subclass

* deprecate RemoteBriefcaseConnection, added RemoteIModelConnection

* extract-api

* rename RemoteIModelConnection to CheckpointConnection

* more documentation

* always import IModelStatus from bentleyjs-core in backend

* fix presentation-backend test failures

* Get presentation update-related tests working again

* Update docs/learning/backend/IModelHost.md

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

* Update core/common/tsconfig.json

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>

* add ProcessDetector

* extract-api

* make StandaloneConnection subclass of BriefcaseConnection

* use IModelDb rather than BriefcaseDb for IModelWriteRpc

* Working mockmobile tests

* restore mobileeventloop

* restored previous mobile ipc fix

* eliminate StandaloneConnection class

* fix openStandalone test

* remove naked require('electron') in favor of ElectronHost.electron

* fix for restarting IModelApp in InteractiveEditingSession.test

* fix interactiveEditingSession test

* fix IModelVersion interface

* fix lint errors

* steps toward getting mobile app working...still an issue in oidc

* typo...authInit being called now. just need a MobileHost.device now, I think

* move websocket ipc to mobilehost...still need to port device over

* IOSDevice back in action. App launches...but no tiles???

* rework IOSHost.startup

* typo

* documentation for TxnManager

* fix lint errors

* rename StandaloneConnection test to OpenStandalone

* ios/mobile refactoring

* api

* add test for classNameToId and classIdToName

* NextVersion.md

* typo

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: swbsi <69857376+swbsi@users.noreply.github.com>

* lint

* extract-api

* merge

* lint errors

* documenation descriptions

* doc errors

* documentation cleanup

* revert ecschema-metadata changes

Co-authored-by: Grigas <35135765+grigasp@users.noreply.github.com>
Co-authored-by: aurislt7 <30312645+aurislt7@users.noreply.github.com>
Co-authored-by: Saulius Skliutas <24278440+saskliutas@users.noreply.github.com>
Co-authored-by: Robert Schili <rschili@users.noreply.github.com>
Co-authored-by: kabentley <33296803+kabentley@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: swbsi <69857376+swbsi@users.noreply.github.com>
Co-authored-by: Caleb Shafer <31107829+calebmshafer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants