Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Upgrade Zod to fix vulnerability #2049

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Upgrade Zod to fix vulnerability #2049

merged 2 commits into from
Oct 24, 2023

Conversation

dhmacs
Copy link
Contributor

@dhmacs dhmacs commented Oct 24, 2023

Zod has patched a Vulnerable email regex: colinhacks/zod#2824 so let's upgrade the dependency in our codebase. It's unlikely though that we're impacted by this as it doesn't seem like we're using .email validation.

qa_req 0

@dhmacs dhmacs added 0 bug Something isn't working security labels Oct 24, 2023
@dhmacs dhmacs self-assigned this Oct 24, 2023
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 5:36pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 5:36pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 333.01 KB (🟡 +2.24 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@dhmacs dhmacs marked this pull request as ready for review October 24, 2023 12:51
masonmcelvain
masonmcelvain previously approved these changes Oct 24, 2023
Copy link
Contributor

@masonmcelvain masonmcelvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👏🏻

Copy link
Contributor

@masonmcelvain masonmcelvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 👏🏻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0 bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants