Move to XMLUnit Legacy (#3235)

* build: migrate to xmlunit 2.9.1 * feat: opt into xxe protection for test suite
iBotPeaches · Jul 30, 2023 · 445da0e · 445da0e
1 parent e19c44b
commit 445da0e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/brut.apktool/apktool-lib/src/test/java/brut/androlib/BaseTest.java b/brut.apktool/apktool-lib/src/test/java/brut/androlib/BaseTest.java
@@ -115,6 +115,8 @@ private void compareXmlFiles(String path, ElementQualifier qualifier) throws Bru
             Reader control = new FileReader(new File(sTestOrigDir, path));
             Reader test = new FileReader(new File(sTestNewDir, path));
 
+            XMLUnit.setEnableXXEProtection(true);
+
             if (qualifier == null) {
                 XMLUnit.setIgnoreWhitespace(true);
                 XMLUnit.setIgnoreAttributeOrder(true);

diff --git a/build.gradle b/build.gradle
@@ -28,7 +28,7 @@ buildscript {
                 proguard_gradle: 'com.guardsquare:proguard-gradle:7.3.2',
                 smali          : 'com.android.tools.smali:smali:3.0.3',
                 xmlpull        : 'xpp3:xpp3:1.1.4c',
-                xmlunit        : 'xmlunit:xmlunit:1.6',
+                xmlunit        : 'org.xmlunit:xmlunit-legacy:2.9.1',
         ]
     }