Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getStorefront method implementation for fetching App Store and Google Play region #2877

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

nahlebn1k
Copy link
Contributor

@nahlebn1k nahlebn1k commented Nov 4, 2024

Hello, I've been using this method in my fork for a while. And i think it would be very usefull to have this in main repo.

@nahlebn1k nahlebn1k changed the title getStorefront method implementation for fetching App Store and Google Play region feat: getStorefront method implementation for fetching App Store and Google Play region Nov 4, 2024
@hyochan hyochan added the ℹ needs more info Needs more detailed information to move forward label Nov 12, 2024
@hyochan
Copy link
Owner

hyochan commented Nov 12, 2024

@nahlebn1k Hi! Thanks for your contribution.

Before diving into the code review, could you please provide a clear explanation of the purpose of this PR? This will help us avoid any potential misunderstandings and ensure we're all on the same page. Thank you!

@nahlebn1k
Copy link
Contributor Author

nahlebn1k commented Nov 12, 2024

@hyochan Hi! The purpose of this PR is to add the ability to determine which App Store or Play Store region user in. In my case i have different in-app purchases and subscriptions packs for different regions. And in order to offer users specific purchases it's necessary to know their Store region.

In addition Android getBillingConfigAsync() method should be used with existing BillingClient, so, in my opinion, the implementation of this feature suggests itself. Thanks in advance!

https://developer.android.com/reference/com/android/billingclient/api/BillingClient#getBillingConfigAsync(com.android.billingclient.api.GetBillingConfigParams,com.android.billingclient.api.BillingConfigResponseListener)

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

LGTM!

@hyochan hyochan added 🤖 android Related to android 📱 iOS Related to iOS 🎯 feature New feature and removed ℹ needs more info Needs more detailed information to move forward labels Dec 18, 2024
@hyochan
Copy link
Owner

hyochan commented Dec 18, 2024

Documentation could be included in the future though!

@hyochan hyochan merged commit 3712d09 into hyochan:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🎯 feature New feature 📱 iOS Related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants