Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haitham dev #7

Closed
wants to merge 0 commits into from
Closed

Haitham dev #7

wants to merge 0 commits into from

Conversation

haithamAbuElnasr
Copy link
Collaborator

No description provided.

Comment on lines 39 to 42
export function createJsonFile(name: string, domain: string) {
const obj = {
name,
domain,
subFinder: defaultToolObj(),
liveDomains: defaultToolObj(),
screenWin: defaultToolObj(),
archive: defaultToolObj(),
waybackurls_js: defaultToolObj(),
waybackurls_parameter: defaultToolObj(),
subFinder: defaultJobDetails,
liveDomains: defaultJobDetails,
screenWin: defaultJobDetails,
archive: defaultJobDetails,
waybackurls_js: defaultJobDetails,
waybackurls_parameter: defaultJobDetails,
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong structure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to be inside recon objcet

@@ -11,6 +11,8 @@ export interface ProjectDetails {
screens?: JobDetails;
params?: JobDetails;
liveDomains?: JobDetails;
archive?: JobDetails;
waybackurls_js?: JobDetails;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use snake case here
wayBackUrlsJs

Copy link
Collaborator

@Mahmoudgalalz Mahmoudgalalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its shit

await db.update({
recon: {
screens: {
result: parseInt(domainsFound, 10),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it '' empty string

Comment on lines 22 to 28
const res = await execAsync(command);
const domainsFound = resultFromStd(res.stderr, /\bFound (\d+) subdomains?/);
const db = connectJson(path.join(`${outputDir}/details.json`));
await db.update({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this regex work ?!

Comment on lines 50 to 56
const res = await execAsync(command);
const domainsFound = resultFromStd(res.stderr, /\bFound (\d+) subdomains?/);
const db = connectJson(path.join(`${outputDir}/details.json`));
await db.update({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines 82 to 88
const res = await execAsync(command);
const domainsFound = resultFromStd(res.stderr, /\bFound (\d+) subdomains?/);
const db = connectJson(path.join(`${outputDir}/details.json`));
await db.update({
recon: {
liveDomains: {
result: parseInt(domainsFound, 10),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@haithamAbuElnasr
Copy link
Collaborator Author

No tool outputs the counter but subfinder , the live domains outputs the domains themself i tryed to count them but already all method doesn't give the output in the run time ,onece i close the app the i find the output files i tryed to use the debug tool the app doesn't go after the awit liveDomian() at all i tryed to put the subfinder command instated of the livedomaind command in same function of the liveDomain method it works normalygit add .

Copy link
Collaborator

@Mahmoudgalalz Mahmoudgalalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default values are not initiated, this is a good way, but need to work on the above requests

src/main/main.ts Outdated
Comment on lines 49 to 75
ipcMain.on('httpx-screens', async (event, args) => {
const { projectName } = args[0];
const res = screenwin(`${PROJECT_DIR}/${projectName}`);
return res;
event.returnValue = res;
});
ipcMain.handle('waybackurls-archive', async (event, args) => {
ipcMain.on('waybackurls-archive', async (event, args) => {
const { projectName } = args[0];
const res = wwayback(`${PROJECT_DIR}/${projectName}`);
return res;
event.returnValue = res;
});
ipcMain.handle('waybackurls-js', async (event, args) => {
ipcMain.on('waybackurls-js', async (event, args) => {
const { projectName } = args[0];
const res = fetchJs(`${PROJECT_DIR}/${projectName}`);
return res;
event.returnValue = res;
});
ipcMain.handle('waybackurls-parameter', async (event, args) => {
ipcMain.on('waybackurls-parameter', async (event, args) => {
const { projectName } = args[0];
const res = parameter(`${PROJECT_DIR}/${projectName}`);
return res;
event.returnValue = res;
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The handler are not correct

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the correct ?
it already works the problem in the tools methos ,it is not here .

const db = connectJson(path.join(`${outputDir}/details.json`));
await db.update({
recon: {
liveDomains: {
result: parseInt(domainsFound, 10),
result: domainsFound,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This return an array, so it should be array.length()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do it look to teh fun imp

@Mahmoudgalalz
Copy link
Collaborator

No tool outputs the counter but subfinder , the live domains outputs the domains themself i tryed to count them but already all method doesn't give the output in the run time ,onece i close the app the i find the output files i tryed to use the debug tool the app doesn't go after the awit liveDomian() at all i tryed to put the subfinder command instated of the livedomaind command in same function of the liveDomain method it works normalygit add .

You need to pass the stderr not stdout as these tools do print in the error stream

@haithamAbuElnasr
Copy link
Collaborator Author

"You need to pass the stderr not stdout as these tools do print in the error stream"
still the problem is not here i commented it and still act the same.

@Mahmoudgalalz
Copy link
Collaborator

can you explain what issue you have !?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants