Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unlock intellisense for the finder component #1104

Merged
merged 4 commits into from
Jan 12, 2025

Conversation

hirasso
Copy link
Contributor

@hirasso hirasso commented Jan 11, 2025

Solves #1097

Before

use Isolated\Symfony\Component\Finder\Finder;

return [
    'finders' => [
        Finder::create()->files()->in('src'),
        // ...
    ],
]

After

/** @var Symfony\Component\Finder\Finder $finder */
$finder = Isolated\Symfony\Component\Finder\Finder::class;

return [
    'finders' => [
        $finder::create()->files()->in('src'),
        // ...
    ],
]
  • Update usage examples in all .md files
  • Update scoper.inc.php.tpl
  • Leave other instances untouched (fixtures, for example)

Notes

A few unrelated (whitespace only) formatting things slipped through in this PR. An .editorconfig or an automated lint step in a GitHub workflow would solve these kinds of issues and would make it easier for people to contribute to php-scoper. In my experience, an .editorconfig is usually enough.

@hirasso hirasso changed the title Feat/finder-intellisense feat: unlock intellisense for the finder component Jan 11, 2025
@hirasso hirasso force-pushed the feat/finder-intellisense branch from e2bc2e1 to 7011c94 Compare January 11, 2025 11:12
@theofidry theofidry marked this pull request as ready for review January 12, 2025 15:43
@theofidry theofidry merged commit d87fdca into humbug:main Jan 12, 2025
126 checks passed
@theofidry
Copy link
Member

Thank you @hirasso!

A few unrelated (whitespace only) formatting things slipped through in this PR. An .editorconfig or an automated lint step in a GitHub workflow would solve these kinds of issues and would make it easier for people to contribute to php-scoper. In my experience, an .editorconfig is usually enough.

I don't mind someone proposing an .editorconfig, but I don't bother actively adding one either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants