Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add question answering to inference client #1609

Merged

Conversation

martinbrose
Copy link
Contributor

@martinbrose martinbrose commented Aug 20, 2023

Add question-answering to HuggingFace🤗 Hub

References #1539

This is an ongoing list of model tasks to implement in the Hugging Face Hub inference client. Each task is planned to be its own PR. The task for this is question-answering.

Key Features

  • Modifies _client.py to call a question-answering model.
  • Modifies testing and documentation to reflect changes.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 20, 2023

The documentation is not available anymore as the PR was closed or merged.

@martinbrose martinbrose changed the title Add question-answering to inference client Add question answering to inference client Aug 21, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 76.92% and project coverage change: -0.52% ⚠️

Comparison is base (c716714) 82.31% compared to head (56b314c) 81.79%.
Report is 1 commits behind head on main.

❗ Current head 56b314c differs from pull request most recent head 839a3a0. Consider uploading reports for the commit 839a3a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1609      +/-   ##
==========================================
- Coverage   82.31%   81.79%   -0.52%     
==========================================
  Files          62       60       -2     
  Lines        6984     6790     -194     
==========================================
- Hits         5749     5554     -195     
- Misses       1235     1236       +1     
Files Changed Coverage Δ
...gingface_hub/inference/_generated/_async_client.py 58.37% <25.00%> (+0.33%) ⬆️
src/huggingface_hub/inference/_client.py 79.51% <100.00%> (-0.30%) ⬇️
src/huggingface_hub/inference/_types.py 96.15% <100.00%> (-0.15%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect job!

docs/source/en/guides/inference.md Outdated Show resolved Hide resolved
src/huggingface_hub/inference/_client.py Outdated Show resolved Hide resolved
src/huggingface_hub/inference/_generated/_async_client.py Outdated Show resolved Hide resolved
tests/test_inference_client.py Outdated Show resolved Hide resolved
@Wauplin Wauplin merged commit e98ada3 into huggingface:main Sep 6, 2023
@martinbrose martinbrose deleted the 1539-InferenceClient-question-answering branch September 6, 2023 16:30
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants