-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object detection to inference client #1548
Add object detection to inference client #1548
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean implementation! Thanks for working on it @dulayjm !
I tested it locally and re-recorded the test (there were 3 requests made, making the file quite huge). Worked like a charm for me at first use :D If everything's fine in the CI, it is ready to be merged straight away 🤗
@Wauplin Thanks! The code seems to still fail the CI, but I have a question about that. On the
|
@dulayjm All failing tests are unrelated. Some tests actually require a production token that is set as a secret on the repo. Since your PR comes from a fork -and to avoid any leaks-, Github doesn't seem to be forwarding the secret values. I thought that when a maintainer (me) triggers it manually the secrets were passed but that doesn't seem to be the case. I'll investigate to check what I could do in PRs from forks (most likely skip the related tests). But anyway, PR is good and related test worked so let's merge it! :) |
Awesome, thank you so much! |
This is really cool! Random unsollicited question, did you try out the huggingface.js implementation? https://huggingface.co/docs/huggingface.js/inference/classes/HfInference#objectdetection (same client, but in JS) |
Thank you!! No, I haven't checked out the JS library, but I'll give it a look! 🤗 |
Add object-detection to HuggingFace🤗 Hub
References Issue #1539
This is an ongoing list of model tasks to implement in the Hugging Face Hub inference client. Each task is planned to be its own PR. The task for this is object-detection.
** Key Features **
_client.py
to call an object detection model. The example model is DETR ResNet-50.