Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove_columns in the formatted case #7358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −14
Open

Fix remove_columns in the formatted case #7358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a13ccf2
align remove_columns in the formatted case
lhoestq Jan 6, 2025
1222bd8
simplify
lhoestq Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
simplify
  • Loading branch information
@lhoestq
lhoestq committed Jan 6, 2025
commit 1222bd876b5f8f2ff0995d43f6e9570e0469d527
7 changes: 2 additions & 5 deletions src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3352,15 +3352,12 @@ def apply_function_on_filtered_inputs(pa_inputs, indices, check_same_num_example
validate_function_output(processed_inputs, indices)
if not update_data:
return None # Nothing to update, let's move on
if shard._format_type or input_columns:
# TODO(QL, MS): ideally the behavior should be the same even if the dataset is formatted (may require major release)
inputs_to_merge = dict(zip(pa_inputs.column_names, pa_inputs.itercolumns()))
elif isinstance(inputs, LazyDict):
if isinstance(inputs, LazyDict):
inputs_to_merge = {
k: (v if k not in inputs.keys_to_format else pa_inputs[k]) for k, v in inputs.data.items()
}
else:
inputs_to_merge = inputs
inputs_to_merge = dict(zip(pa_inputs.column_names, pa_inputs.itercolumns()))
if remove_columns is not None:
for column in remove_columns:
# `function` can modify input in-place causing column to be already removed.
Expand Down
Loading