Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI test_convert_to_parquet #7078

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Fix CI test_convert_to_parquet #7078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e752cc1
Unmark test_convert_to_parquet as xfail
albertvillanova Jul 27, 2024
f380cbe
Fix test_convert_to_parquet by patching HfApi.preupload_lfs_files
albertvillanova Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tests/test_hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ def test_dataset_url(repo_id, filename, revision):
assert url == f"https://huggingface.co/datasets/{repo_id}/resolve/{revision or 'main'}/{quote(filename)}"


# Temporarily mark this test as expected to fail: GH-7073
@pytest.mark.xfail
def test_convert_to_parquet(temporary_repo, hf_api, hf_token, ci_hub_config, ci_hfh_hf_hub_url):
with temporary_repo() as repo_id:
hf_api.create_repo(repo_id, token=hf_token, repo_type="dataset")
Expand All @@ -64,7 +62,8 @@ def test_convert_to_parquet(temporary_repo, hf_api, hf_token, ci_hub_config, ci_
with patch.object(datasets.hub.HfApi, "create_commit", return_value=commit_info) as mock_create_commit:
with patch.object(datasets.hub.HfApi, "create_branch") as mock_create_branch:
with patch.object(datasets.hub.HfApi, "list_repo_tree", return_value=[]): # not needed
_ = convert_to_parquet(repo_id, token=hf_token, trust_remote_code=True)
with patch.object(datasets.hub.HfApi, "preupload_lfs_files", return_value=None): # not needed
_ = convert_to_parquet(repo_id, token=hf_token, trust_remote_code=True)
# mock_create_branch
assert mock_create_branch.called
assert mock_create_branch.call_count == 2
Expand Down
Loading