Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming] retry on requests errors #6963

Merged
merged 3 commits into from
Jun 28, 2024
Merged

[Streaming] retry on requests errors #6963

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9c8655
[Streaming] retry on requests errors
lhoestq Jun 10, 2024
3e05f34
Merge branch 'main' into stream-etry-on-requests-errors
lhoestq Jun 28, 2024
6cd13c1
lucain's comment
lhoestq Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/datasets/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,12 @@ def read_with_retries(*args, **kwargs):
try:
out = read(*args, **kwargs)
break
except (ClientError, TimeoutError) as err:
except (
ClientError,
TimeoutError,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Those two correspond to aiohttp.client_exceptions.ClientError and asyncio.TimeoutError. I think it's best to explicitly name them as you did with requests.exceptions.ConnectTimeout. It was not obvious for me at first (I wondered what was the difference between those 4 only to figure out it was not only requests errors)

requests.exceptions.ConnectTimeout,
requests.exceptions.ConnectionError,
) as err:
disconnect_err = err
logger.warning(
f"Got disconnected from remote data host. Retrying in {config.STREAMING_READ_RETRY_INTERVAL}sec [{retry}/{max_retries}]"
Expand Down
Loading