Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX] typo in the import path for metrics #1789

Merged
merged 1 commit into from
Jan 28, 2021
Merged

[BUG FIX] typo in the import path for metrics #1789

merged 1 commit into from
Jan 28, 2021

Conversation

yjernite
Copy link
Member

This tiny PR fixes a typo introduced in #1726 which prevents loading new metrics

@yjernite yjernite requested a review from lhoestq January 28, 2021 18:01
lhoestq
lhoestq approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this !
It was not caught by the tests because the metrics are still missing certain tests. But adding these tests is in scope for 2.0, I'll add some soon

@yjernite yjernite merged commit 64d394e into huggingface:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjernite @lhoestq