Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade starlette everywhere #2401

Merged
merged 4 commits into from
Feb 5, 2024
Merged

upgrade starlette everywhere #2401

merged 4 commits into from
Feb 5, 2024

Conversation

severo
Copy link
Collaborator

@severo severo commented Feb 5, 2024

#2400 was not complete


still wip, because of starlette middleware types (encode/starlette#2180, encode/starlette#2381).

it was a matter of upgrading mypy ahah

@severo severo marked this pull request as draft February 5, 2024 18:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b316bf) 90.51% compared to head (d39e8fe) 92.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2401      +/-   ##
==========================================
+ Coverage   90.51%   92.75%   +2.24%     
==========================================
  Files         142       91      -51     
  Lines        8348     6075    -2273     
==========================================
- Hits         7556     5635    -1921     
+ Misses        792      440     -352     
Flag Coverage Δ
jobs_mongodb_migration ?
libs_libcommon ?
services_admin ?
services_rows ?
services_search ?
services_sse-api ?
services_worker 92.75% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@severo severo marked this pull request as ready for review February 5, 2024 21:19
@severo severo merged commit 2a03140 into main Feb 5, 2024
24 checks passed
@severo severo deleted the upgrade-starlette-bis branch February 5, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants