fix(dev-server): Fix issue in dev-server where requestListener would return null

[gobengo]

I was running into an error using honox, this vite dev server plugin, and hono node-server.

The error stack in prod is like

file:///app/node_modules/@hono/node-server/dist/index.mjs:345
   if (cacheKey in res) {
                ^
 
 TypeError: Cannot use 'in' operator to search for 'Symbol(cache)' in null
     at responseViaResponseObject (file:///app/node_modules/@hono/node-server/dist/index.mjs:345:16)
     at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
 
 Node.js v23.3.0

I believe that comes from the cacheKey in res here /~https://github.com/honojs/node-server/blob/590fe6cef8a795ea10c300033387f13ed31e144f/src/listener.ts#L86

But that is downstream from calling requestListener to get a Promise.

Before this change, if the response from the router has reuest.body === null (e.g. a Response with status 404 and no response body), then the dev-server will return null here, not a response, and downstream things that expect a response (like node-server) will error.

This change makes it so if the dev server is unable to inject script into response to build a new response (e.g. when there is no response.body at all), a response is still returned.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4c9a223

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@hono/vite-dev-server	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gobengo]

wdyt @yusukebe ?

[gobengo]

Oh. I also just found this /~https://github.com/honojs/hono/pull/1142/files#diff-f42b11987a9538ff250a31ba4eb66ee557f7512860fae88c5020a83b5e97c28cR278
which seems to be the origin of the HEAD requests getting a response with body null.
iiuc without this change, any hono app using vite-dev-server here will crash when responding to HEAD requests.

[gobengo]

I verified that a brand new honox app created via create-hono-app x-basic crashes with curl locahost:5173 -X HEAD. I think this PR would fix that

[yusukebe]

LGTM!

[yusukebe]

Hi @gobengo !

Good fix! I've added a test for it by myself. Looks good. I'll merge this and release a new version. Thank you for your contribution.

[gobengo]

I'll merge this and release a new version.

Thanks!

Thank you for your contribution.

You're welcome. my pleasure