feat: support classic ingest keys, upgrade to libhoney 4.2.0 #726
Conversation
cewkrupa
added
dependencies
| @@ -5,9 +5,9 @@ const process = require("process"), | |||
| tracker = require("../async_tracker"), | |||
| pkg = require("../../package.json"), | |||
| debug = require("debug")(`${pkg.name}:event`), | |||
| libhoney = require("libhoney"), | |||
There was a problem hiding this comment.
Do we need two require's for libhoney and LibhoneyImpl?
PS I prefer libhoney over LibhoneyImpl if we can just keep line.
There was a problem hiding this comment.
Yes I think we do need both, since the LibhoneyImpl is coming from ./libhoney.js in this repo while libhoney is coming direct from the libhoney-js package as libhoney.
There was a problem hiding this comment.
Interesting, I didn't notice the local reference for LibhoneyImpl 👍🏻 It's kinda weird we have a file named the same as one of our dependencies (which we maintain :)).
MikeGoldsmith
added
type: enhancement
| @@ -5,9 +5,9 @@ const process = require("process"), | |||
| tracker = require("../async_tracker"), | |||
| pkg = require("../../package.json"), | |||
| debug = require("debug")(`${pkg.name}:event`), | |||
| libhoney = require("libhoney"), | |||
There was a problem hiding this comment.
Interesting, I didn't notice the local reference for LibhoneyImpl 👍🏻 It's kinda weird we have a file named the same as one of our dependencies (which we maintain :)).
MikeGoldsmith
deleted the
cewkrupa/support-classic-ingest-keys-bump-libhoney
branch
Which problem is this PR solving?
We recently updated libhoney-js to support classic ingest keys. This PR updates the beeline to this version of libhoney-js and swaps
isClassicto use the new exported method from libhoney.Short description of the changes
4.0.0to4.2.0utils.isClassicin favor oflibhoney.isClassic