Skip to content

Commit

Permalink
isis: fix processing of outdated LSPs
Browse files Browse the repository at this point in the history
When receiving an LSP that is older than the one stored in the
database, we should send back the database's LSP instead of the
received LSP.

This is a really serious bug that could cause major issues in the
right conditions.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
  • Loading branch information
rwestphal committed Feb 25, 2025
1 parent 3b19b33 commit bf32e13
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion holo-isis/src/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -676,9 +676,11 @@ pub(crate) fn process_pdu_lsp(
}
}
Some(Ordering::Greater) => {
let lse = lse.unwrap();

// Update LSP flooding flags for the incoming interface.
let lsp_id = lsp.lsp_id;
iface.srm_list_add(instance, level, lsp);
iface.srm_list_add(instance, level, lse.data.clone());
iface.ssn_list_del(level, &lsp_id);
}
}
Expand Down

0 comments on commit bf32e13

Please sign in to comment.