NFDIV-4420 - Invite citizen when solicitor stops representation #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamg-hmcts
reviewed
Jan 3, 2025
Comment on lines
150
to
158
| notificationDispatcher.sendNOC(nocSolRemovedSelfNotifications, details.getData(), | ||
| beforeDetails.getData(), details.getId(), wasRepresentingApplicant1, NoticeType.ORG_REMOVED); | ||
|
|
||
| if (data.getApplicationType() == ApplicationType.SOLE_APPLICATION) { | ||
| final var applicant = wasRepresentingApplicant1 ? data.getApplicant1() : data.getApplicant2(); | ||
| generateCaseInvite(data, wasRepresentingApplicant1, applicant); | ||
| notificationDispatcher.sendNOCCaseInvite(nocSolRemovedSelfNotifications, details.getData(), details.getId(), | ||
| wasRepresentingApplicant1); | ||
| } |
There was a problem hiding this comment.
If I'm not mistaken, across the NoC events (caseworkerNoticeOfChange, solicitorStopRepresentingClient), we send the case invite whenever the notice type is ORG_REMOVED and the application type is sole. As most of the logic for NoC notifications is in sendNOC, I'm thinking about whether it would be beneficial to remove sendNOCCaseInvite and move the logic for the case invite notification into the sendNOC method, allowing us consolidate the notification logic into 1 method and remove duplication from the NoC events?
Suggested change
| notificationDispatcher.sendNOC(nocSolRemovedSelfNotifications, details.getData(), | |
| beforeDetails.getData(), details.getId(), wasRepresentingApplicant1, NoticeType.ORG_REMOVED); | |
| if (data.getApplicationType() == ApplicationType.SOLE_APPLICATION) { | |
| final var applicant = wasRepresentingApplicant1 ? data.getApplicant1() : data.getApplicant2(); | |
| generateCaseInvite(data, wasRepresentingApplicant1, applicant); | |
| notificationDispatcher.sendNOCCaseInvite(nocSolRemovedSelfNotifications, details.getData(), details.getId(), | |
| wasRepresentingApplicant1); | |
| } | |
| notificationDispatcher.sendNOC(nocSolRemovedSelfNotifications, details.getData(), | |
| beforeDetails.getData(), details.getId(), wasRepresentingApplicant1, NoticeType.ORG_REMOVED); |
Plan Result (aat) |
Plan Result (prod) |
adamg-hmcts
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
When a solicitor has stopped representation (NFDIV-4234), then system must invite the citizen to the case by sending them letter and an email (if email address available). This is only for SOLE cases. Changes for NFDIV-4234 has been included in this PR to build this PR. on top of NFDIV-4355.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/NFDIV-4420