Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CI improvements from main to 6.4 (partially) #9177

Merged
merged 4 commits into from
Oct 29, 2024

Conversation

yrodiere
Copy link
Member

Similar to #9176 , but more conservative as we didn't publish build scan from GitHub Actions in this branch.

This is a backport of #9163 (limited to two commits) #9165 #9166.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


beikov and others added 4 commits October 28, 2024 17:14
So that we're extra sure we're not relying on cache left by a previous
Gradle execution.

(cherry picked from commit 543e095)
Ripped off from Quarkus.

Here's how it will work:

1. We create a cache entry on push only. Pull requests only restore it.
2. We create a new cache entry every day, prefixed with something like
   2024-10-25.
3. When restoring the cache, we try the entry for the day first
   (2024-10-25) and default to the one for the month (2024-10-*).
   Critically, this means we will build each day's cache based on the
   previous day's cache.
4. Atlas infra uses its own, separate cache entries.

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>
(cherry picked from commit 5eaaff2)
We don't need the whole cache, since most (all?) of it is stored on
Develocity already.

Including ./gradle/caches/modules-2 is enough, because that's where
Maven dependencies are stored, and *those* are not stored on Develocity.

(cherry picked from commit 013bb46)
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 28, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [5741bab]

› This message was automatically generated.

@yrodiere yrodiere changed the title Backport GitHub Actions rework from main to 6.4 (partially) Backport CI improvements from main to 6.4 (partially) Oct 28, 2024
@beikov beikov merged commit cca12b9 into hibernate:6.4 Oct 29, 2024
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants