Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Namespace override #19974

Closed
wants to merge 30 commits into from
Closed

[stable/prometheus-operator] Namespace override #19974

wants to merge 30 commits into from

Conversation

YoninL
Copy link

@YoninL YoninL commented Jan 9, 2020

What this PR does / why we need it:
It adds a namespaceOverride parameter, which allows this chart to be used in cases where templating is used across namespaces. By providing this parameter, the resulting templating will output to the specified namespace.

Special notes for your reviewer:
This change is needed for implementing #18837 and inspired by #18986

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YoninL
To complete the pull request process, please assign gianrubio
You can assign the PR to them by writing /assign @gianrubio in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @YoninL. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2020
travisgroth and others added 24 commits January 9, 2020 10:44
@travisgroth @yoninl2
[stable/pomerium] Add option to configure forward-auth automatically (#…
df74dea 
…19900)

Signed-off-by: Travis Groth <tgroth@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@mpolednik @yoninl2
[stable/prometheus-operator] fix comment in values.yaml (kubeSchedule…
4e4337a 
…r) (#19875)

Comment in values.yaml related to kubeScheduler scraping
configuration incorrectly referred to kube-controller-manager
scraping.

Only the comment is fixed as the logic is correct.

Signed-off-by: Martin Polednik <m.polednik@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@yoninl2
[bitnami/ghost] Provide a way to disable readiness/liveness probes (#…
12971bf 
…19907)

Signed-off-by: juan131 <juan@bitnami.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@clamoriniere @yoninl2
[stable/datadog] fix when (#19877)
b5d96b8 
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@hbagdi @yoninl2
[stable/kong] 0.35 update all standard labels (#19856)
a733d7d 
The following document describes all the standard labels that charts
should include:
https://v2.helm.sh/docs/chart_best_practices/#standard-labels

Kong's chart already had these but the keys were outdated.
This commit also de-duplicates these data to further DRY out these
labels.

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@hbagdi @yoninl2
[stable/kong] 0.35.1 mutliple small fixes (#19914)
fa881c1 
* [stable/kong] add rainest as a maintainer

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] update CRDs to Ingress Controller 0.7

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] standardize and optimize readiness and liveness probes

- Initial delay has been lowered to 5 seconds for increased responsiveness
- Frequency is now 10 seconds, again for reponsiveness
- timeout has been standardized to 1s

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] 0.35.1 changelog

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] remove the extra space in NOTES.txt

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] fix values.yalm ingress tls section

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@nareshnayini @yoninl2
fix overwriteConfig condition (#19910)
1aaf143 
Signed-off-by: naresh@getsidecar.com <naresh@getsidecar.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@Graham42 @madelinevdp @yoninl2
[stable/nginx-ingress] Fix ClusterRole creation when using namespaces (…
9c2a896 
…#19886)

* [stable/nginx-ingress] Fix ClusterRole creation when using namespaces

We want to be able to choose to deploy to a namespace and still opt-in
to ClusterRole creation.

Fixes: #18420

Signed-off-by: Graham McGregor <graham@gmcgregor.ca>

Co-authored-by: Madeline Van Der Paelt <madd_y@hotmail.com>

* [stable/nginx-ingress] Bump nginx-ingress chart version

Signed-off-by: Graham McGregor <graham@gmcgregor.ca>

Co-authored-by: Madeline Van Der Paelt <madd_y@hotmail.com>

Co-authored-by: maddster82 <madd_y@hotmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@rifelpet @yoninl2
[stable/kong] Improve deployment label selector to not change on char…
2aba96a 
…t upgrades (#19916)

Signed-off-by: Peter Rifel <pgrifel@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@bitnami-bot @yoninl2
[stable/phpmyadmin] Release 4.2.6 updating components versions (#19931)
9264b13 
Signed-off-by: Bitnami Containers <containers@bitnami.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@yoninl2
[stable/sysdig] Enable Sysdig Secure by default (#19935)
7a24636 
Signed-off-by: Néstor Salceda <nestor.salceda@sysdig.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@wilmardo @yoninl2
[stable/sentry] Makes changing the secreyKey possible (#19938)
75e1c9a 
* feat: make specifiying email secret key possible

Signed-off-by: wilmardo <info@wilmardenouden.nl>

* feat: make specifiying postgresql secret key possible

Signed-off-by: wilmardo <info@wilmardenouden.nl>

* feat: make specifiying redis secret key possible

Signed-off-by: wilmardo <info@wilmardenouden.nl>

* chore: bump chartVersion

Signed-off-by: wilmardo <info@wilmardenouden.nl>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@secret104278 @yoninl2
[stable/nginx-ingress] Add fine-grained host port range in psp (#19858)
2643367 
Give port-by-port permission in psp to improve security.

Signed-off-by: Yu Chih <secret104278@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@devOpsHelm @yoninl2
Add missing LOGGING_LEVEL env variables (#88) (#19944)
0d84b2c 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@rifelpet @yoninl2
[stable/kong] Add missing watch permissions to custom resources (#19946)
3552438 
Signed-off-by: Peter Rifel <pgrifel@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@darkstarmv @yoninl2
[stable/prometheus-blackbox-exporter] Fix PodDisruptionBudget configu…
2696f51 
…ration (#19707)

* Fix PodDisruptionBudget configuration

Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>

* simplify -podDisruptionBudget configuration management

Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>

* Update readme

Signed-off-by: Maxim Valiarovski <maxim.valiarovski@target.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@naseemkullah @yoninl2
[stable/nginx-ingress] If clusterIPs are set, they will automatically…
35425ee 
… be quoted (#19765)

* If clusterIPs are set, they will automatically be quoted

Signed-off-by: Naseem <naseemkullah@gmail.com>

* bump version

Signed-off-by: Naseem <naseemkullah@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@gzur @yoninl2
[stable/minio] Decouple directory root from the mountPath (#19949)
90a1896 
* [stable/minio] Decouple directory root from the mountPath

Introduce a new variable named `.Values.bucketRoot` which defaults to
`.Values.mountPath` if unset.

This allows the Helm chart to serve only a subset of the mounted drive,
which can be useful if the mounted data contains symlinks to locations
that should not be accessible directly through minio.

Addresses #19939

Signed-off-by: gzur <gzur@gzur.org>

* Remove extra spaces

Signed-off-by: gzur <gzur@gzur.org>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@moreginger @yoninl2
Allow a NodePort to be specified. (#19932)
e7106b8 
Signed-off-by: Tim Moore <moreginger@warpmail.net>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@hbagdi @yoninl2
[stable/kong] 0.36.2 timeout and admission controller fixes (#19955)
c550277 
* [stable/kong] add sideEffects and admissionReviewVersions

These are required fields for v1 and we operate on v1beta but support
the v1 resources as well.

Also removed the sym link to default values and introduced a blank file.

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] use service type NodePort for CI testing

kind doesn't support services of type LoadBalancer and the CI test fail
on kind.

This is part of the effort to move the chart under Kong's Github
organization and deprecate it from `helm/charts` repo on Github.

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] 0.36.2 admission webhook fixes

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>

* [stable/kong] bump up timeouts to 5 seconds

On constrained hardware and especially Minikube, 1 second timeouts are
common. Possibly, due to triple scheduling going on.

Signed-off-by: Harry Bagdi <harrybagdi@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@adamkpickering @yoninl2
stable/prometheus Updated README.md with instructions for configuring…
2cbef2e 
… pod scraping (#19379)

* Updated README.md with instructions for configuring pod scraping

Signed-off-by: Adam Pickering <adamkpickering@gmail.com>

* Updated chart version to latest.

Signed-off-by: Adam Pickering <adamkpickering@gmail.com>

* Bumped version to be in sync... again

Signed-off-by: Adam Pickering <adamkpickering@gmail.com>

* Bumped chart version

Signed-off-by: Adam Pickering <adamkpickering@gmail.com>

* Bumped version again

Signed-off-by: Adam Pickering <adamkpickering@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@bitnami-bot @yoninl2
[stable/parse] Release 10.3.1 updating components versions (#19952)
958bd1e 
Signed-off-by: Bitnami Containers <containers@bitnami.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@bitnami-bot @yoninl2
[stable/phpbb] Release 7.0.2 updating components versions (#19962)
b9ee060 
Signed-off-by: Bitnami Containers <containers@bitnami.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@maximeguillet @yoninl2
[stable/prometheus-pushgateway] Allow to specify the nodePort when se…
6cf0f71 
…rvice type is NodePort (#19936)

Signed-off-by: Maxime Guillet <mguillet@mailjet.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
jfcoz and others added 5 commits January 9, 2020 10:44
@jfcoz @yoninl2
add source ip preservation detail (#19942)
4f0850c 
add source ip preservation detail and change default externalTrafficPolicy to Local (default controller.service.type is LoadBalancer)

Signed-off-by: jfcoz <you@example.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@dgomezleon @yoninl2
[stable/mediawiki] Add Mediawiki host parameter (#19834)
118742f 
* [stable/mediawiki] Add Mediawiki host parameter

Signed-off-by: David Gomez <dgomezleon@vmware.com>

* Apply feedback to fix NOTES.txt

Signed-off-by: David Gomez <dgomezleon@vmware.com>

* Add httpHeaders to readiness and liveness probes

Signed-off-by: David Gomez <dgomezleon@vmware.com>

* Access api.php for readiness

Signed-off-by: David Gomez <dgomezleon@vmware.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@dawidmalina @yoninl2
File system 'fs-12345678' does not exist (#19970)
71c901a 
* File system 'fs-12345678' does not exist

Fix issue related to default file system id:
```
W0109 08:06:08.407526 1 efs-provisioner.go:91] couldn't confirm that the EFS file system exists: FileSystemNotFound: File system 'fs-12345678' does not exist.
```

Signed-off-by: Dawid Malinowski <dawidmalina@gmail.com>

* Update Chart.yaml

Signed-off-by: Dawid Malinowski <dawidmalina@gmail.com>
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@yoninl2
namespace override
c3705c6 
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@yoninl2
bump version to 8.5.5
3ad2fbd 
Signed-off-by: Jeremy <yong.jiang1@hp.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2020
@helm-bot helm-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2020
@YoninL
Copy link
Author

YoninL commented Jan 10, 2020

My helm lint . here is all OK, my helm version is 2.16.1.

@stale
Copy link

stale bot commented Feb 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2020
@stale
Copy link

stale bot commented Feb 23, 2020

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Feb 23, 2020
@mforutan
Copy link

mforutan commented Mar 2, 2020

hi @bismarck and @gianrubio, can we please re-open this? what is the next step for this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bismarck bismarck Awaiting requested review from bismarck

@gianrubio gianrubio Awaiting requested review from gianrubio

Assignees
No one assigned
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.