Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nginx-ingress] If clusterIPs are set, they will automatically be quoted #19765

Merged
merged 5 commits into from
Jan 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/nginx-ingress/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: nginx-ingress
version: 1.28.1
version: 1.28.2
appVersion: 0.26.2
home: /~https://github.com/kubernetes/ingress-nginx
description: An nginx Ingress controller that uses ConfigMap to store the nginx configuration.
Expand Down
2 changes: 1 addition & 1 deletion stable/nginx-ingress/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -320,4 +320,4 @@ Error: UPGRADE FAILED: Service "?????-controller" is invalid: spec.clusterIP: In

Detail of how and why are in [this issue](/~https://github.com/helm/charts/pull/13646) but to resolve this you can set `xxxx.service.omitClusterIP` to `true` where `xxxx` is the service referenced in the error.

As of version `1.26.0` of this chart, by simply not providing any clusterIP value, `invalid: spec.clusterIP: Invalid value: "": field is immutable` will no longer occur since `clusterIP: ""` will not be rendered. If you do wish to provide a clusterIP value in your values file, ensure that it is quoted.
As of version `1.26.0` of this chart, by simply not providing any clusterIP value, `invalid: spec.clusterIP: Invalid value: "": field is immutable` will no longer occur since `clusterIP: ""` will not be rendered.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ metadata:
name: {{ template "nginx-ingress.controller.fullname" . }}-metrics
spec:
{{- if not .Values.controller.metrics.service.omitClusterIP }}
{{ with .Values.controller.metrics.service.clusterIP }}clusterIP: {{ . }}{{ end }}
{{ with .Values.controller.metrics.service.clusterIP }}clusterIP: {{ . | quote }}{{ end }}
{{- end }}
{{- if .Values.controller.metrics.service.externalIPs }}
externalIPs:
Expand Down
2 changes: 1 addition & 1 deletion stable/nginx-ingress/templates/controller-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ metadata:
name: {{ template "nginx-ingress.controller.fullname" . }}
spec:
{{- if not .Values.controller.service.omitClusterIP }}
{{ with .Values.controller.service.clusterIP }}clusterIP: {{ . }}{{ end }}
{{ with .Values.controller.service.clusterIP }}clusterIP: {{ . | quote }}{{ end }}
{{- end }}
{{- if .Values.controller.service.externalIPs }}
externalIPs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ metadata:
name: {{ template "nginx-ingress.controller.fullname" . }}-admission
spec:
{{- if not .Values.controller.admissionWebhooks.service.omitClusterIP }}
{{ with .Values.controller.admissionWebhooks.service.clusterIP }}clusterIP: {{ . }}{{ end }}
{{ with .Values.controller.admissionWebhooks.service.clusterIP }}clusterIP: {{ . | quote }}{{ end }}
{{- end }}
{{- if .Values.controller.admissionWebhooks.service.externalIPs }}
externalIPs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ metadata:
name: {{ template "nginx-ingress.defaultBackend.fullname" . }}
spec:
{{- if not .Values.defaultBackend.service.omitClusterIP }}
{{ with .Values.defaultBackend.service.clusterIP }}clusterIP: {{ . }}{{ end }}
{{ with .Values.defaultBackend.service.clusterIP }}clusterIP: {{ . | quote }}{{ end }}
{{- end }}
{{- if .Values.defaultBackend.service.externalIPs }}
externalIPs:
Expand Down