Skip to content

Commit

Permalink
Update docs for Helm 3 (#194)
Browse files Browse the repository at this point in the history
Signed-off-by: Reinhard Naegele <unguiculus@gmail.com>
  • Loading branch information
unguiculus authored Dec 13, 2019
1 parent b9d4ad0 commit 62e23ac
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 25 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Run the script specifying the version for the new release.
./tag.sh --tag <release_version>
```

Versions must start with a lower-case `v`, e. g. `v2.4.0`.
Versions must start with a lower-case `v`, e. g. `v3.0.0`.


## Supported versions
Expand Down
2 changes: 1 addition & 1 deletion ct/cmd/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func addInstallFlags(flags *flag.FlagSet) {
the ID of a pull request. If not specified, the name of the chart is used`))
flags.String("helm-extra-args", "", heredoc.Doc(`
Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500 --tiller-namespace tiller"`))
(e.g. "--timeout 500"`))
flags.Bool("upgrade", false, heredoc.Doc(`
Whether to test an in-place upgrade of each chart from its previous revision if the
current version should not introduce a breaking change according to the SemVer spec`))
Expand Down
2 changes: 1 addition & 1 deletion doc/ct.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ in given chart directories.
* [ct list-changed](ct_list-changed.md) - List changed charts
* [ct version](ct_version.md) - Print version information

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
4 changes: 2 additions & 2 deletions doc/ct_install.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ ct install [flags]
--excluded-charts strings Charts that should be skipped. May be specified multiple times
or separate values with commas
--helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500 --tiller-namespace tiller"
(e.g. "--timeout 500"
--helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be
specified on a per-repo basis with an equals sign as delimiter
(e.g. 'myrepo=--username test --password secret'). May be specified
Expand All @@ -71,4 +71,4 @@ ct install [flags]

* [ct](ct.md) - The Helm chart testing tool

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
4 changes: 2 additions & 2 deletions doc/ct_lint-and-install.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ct lint-and-install [flags]
--excluded-charts strings Charts that should be skipped. May be specified multiple times
or separate values with commas
--helm-extra-args string Additional arguments for Helm. Must be passed as a single quoted string
(e.g. "--timeout 500 --tiller-namespace tiller"
(e.g. "--timeout 500"
--helm-repo-extra-args strings Additional arguments for the 'helm repo add' command to be
specified on a per-repo basis with an equals sign as delimiter
(e.g. 'myrepo=--username test --password secret'). May be specified
Expand Down Expand Up @@ -66,4 +66,4 @@ ct lint-and-install [flags]

* [ct](ct.md) - The Helm chart testing tool

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
2 changes: 1 addition & 1 deletion doc/ct_lint.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ ct lint [flags]

* [ct](ct.md) - The Helm chart testing tool

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
2 changes: 1 addition & 1 deletion doc/ct_list-changed.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ ct list-changed [flags]

* [ct](ct.md) - The Helm chart testing tool

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
2 changes: 1 addition & 1 deletion doc/ct_version.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ ct version [flags]

* [ct](ct.md) - The Helm chart testing tool

###### Auto generated by spf13/cobra on 21-Mar-2019
###### Auto generated by spf13/cobra on 13-Dec-2019
2 changes: 1 addition & 1 deletion examples/docker-for-mac/my_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ set -o errexit
set -o nounset
set -o pipefail

readonly IMAGE_TAG=v2.4.0
readonly IMAGE_TAG=v3.0.0
readonly IMAGE_REPOSITORY="quay.io/helmpack/chart-testing"

main() {
Expand Down
2 changes: 1 addition & 1 deletion examples/gke/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM quay.io/helmpack/chart-testing:v2.4.0
FROM quay.io/helmpack/chart-testing:v3.0.0

ENV PATH /google-cloud-sdk/bin:$PATH
ARG CLOUD_SDK_VERSION=221.0.0
Expand Down
2 changes: 1 addition & 1 deletion examples/kind/.circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:

lint-charts:
docker:
- image: quay.io/helmpack/chart-testing:v2.4.0
- image: quay.io/helmpack/chart-testing:v3.0.0
steps:
- checkout
- run:
Expand Down
11 changes: 1 addition & 10 deletions examples/kind/test/e2e-kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -o errexit
set -o nounset
set -o pipefail

readonly CT_VERSION=v2.4.0
readonly CT_VERSION=v3.0.0
readonly KIND_VERSION=v0.5.1
readonly CLUSTER_NAME=chart-testing
readonly K8S_VERSION=v1.15.3
Expand Down Expand Up @@ -57,14 +57,6 @@ create_kind_cluster() {
echo
}

install_tiller() {
echo 'Installing Tiller...'
docker_exec kubectl --namespace kube-system create sa tiller
docker_exec kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller
docker_exec helm init --service-account tiller --upgrade --wait
echo
}

install_local-path-provisioner() {
# kind doesn't support Dynamic PVC provisioning yet, this is one ways to get it working
# /~https://github.com/rancher/local-path-provisioner
Expand All @@ -88,7 +80,6 @@ main() {

create_kind_cluster
install_local-path-provisioner
install_tiller
install_charts
}

Expand Down
2 changes: 0 additions & 2 deletions pkg/chart/chart.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ type Git interface {

// Helm is the interface that wraps Helm operations
//
// Init runs client-side Helm initialization
//
// AddRepo adds a chart repository to the local Helm configuration
//
// BuildDependencies builds the chart's dependencies
Expand Down

0 comments on commit 62e23ac

Please sign in to comment.