Skip to content

Commit

Permalink
[AUDIO_WORKLET] Fix when compiling with STRICT (emscripten-core#23130)
Browse files Browse the repository at this point in the history
Fix for emscripten-core#22971.

This highlights that the AW tests weren't catching this or other issues
in the parameterised tests. Running, for example:
```
test/runner browser.test_audio_worklet_strict
```
Passes, but if compiled with the same settings doesn't run.
  • Loading branch information
cwoffenden authored and hedwigz committed Dec 18, 2024
1 parent 8852761 commit 1aea351
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/link.py
Original file line number Diff line number Diff line change
Expand Up @@ -1409,6 +1409,8 @@ def phase_linker_setup(options, state, newargs): # noqa: C901, PLR0912, PLR0915
# MINIMAL_RUNTIME exports these manually, since this export mechanism is placed
# in global scope that is not suitable for MINIMAL_RUNTIME loader.
settings.EXPORTED_RUNTIME_METHODS += ['stackSave', 'stackAlloc', 'stackRestore', 'wasmTable']
# The following symbols need exposing to load and bootstrap the audio worklet:
settings.INCOMING_MODULE_JS_API += ['instantiateWasm', 'wasm', 'wasmMemory']

if settings.FORCE_FILESYSTEM and not settings.MINIMAL_RUNTIME:
# when the filesystem is forced, we export by default methods that filesystem usage
Expand Down

0 comments on commit 1aea351

Please sign in to comment.