Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Bug fix for double slash in LIST endpoint into release/1.15.x #23450

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23446 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


This UI only regression bug was potentially introduced by this PR.

The reproduction steps of how the bug was reported:

  1. on a binary
  2. Create a namespace
  3. Within the namespace mount the auth method userpass.
  4. Create a user userpass and navigate to the list view. No users would show and there was a 301 followed by a 404 error on the network request on this LIST endpoint. if you look closely, you'll see a double forward slash.
    http://localhost:4200/v1/auth/userpass/users//?list=true

This fix cleans out the double forward slash and resolves the issue. The sanitizePath method removes any whitespace and trailing and leading slashes.

TODO:

  • test to make sure doesn't break anything ✅
  • run enterprise tests locally. ✅

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-20546/regression-bug/strongly-thorough-dodo branch from 0199b9e to f71e462 Compare October 2, 2023 20:37
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 8:43pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 2, 2023
@Monkeychip Monkeychip added this to the 1.15.1 milestone Oct 2, 2023
@Monkeychip Monkeychip enabled auto-merge (squash) October 2, 2023 20:38
@Monkeychip Monkeychip merged commit 08dc887 into release/1.15.x Oct 2, 2023
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Build Results:
All builds succeeded! ✅

@Monkeychip Monkeychip deleted the backport/ui/VAULT-20546/regression-bug/strongly-thorough-dodo branch October 2, 2023 20:56
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants