Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clone vault agent client with headers #15274

Merged
merged 1 commit into from
May 3, 2022
Merged

clone vault agent client with headers #15274

merged 1 commit into from
May 3, 2022

Conversation

ccapurso
Copy link
Contributor

@ccapurso ccapurso commented May 3, 2022

#15204 introduced a change in which the Vault client is cloned for the auth handler. The headers are not cloned, however, which results in headers like X-Vault-Namespace being dropped. This PR changes the Clone call to a CloneWithHeaders.

@ccapurso ccapurso requested a review from jasonodonnell May 3, 2022 19:49
jasonodonnell
jasonodonnell approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for fixing!

@ccapurso ccapurso merged commit 836ed70 into main May 3, 2022
@ccapurso ccapurso deleted the fix-clone-agent-client-with-headers branch May 3, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
pr/no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccapurso @jasonodonnell