Reinstate testing token helper but in original command/token package

command/auth_test.go

@@ -7,7 +7,7 @@ import (
 	"testing"
 
 	"github.com/hashicorp/cli"
-	"github.com/hashicorp/vault/api/tokenhelper"
+	"github.com/hashicorp/vault/command/token"
 )
 
 func testAuthCommand(tb testing.TB) (*cli.MockUi, *AuthCommand) {
@@ -19,7 +19,7 @@ func testAuthCommand(tb testing.TB) (*cli.MockUi, *AuthCommand) {
 			UI: ui,
 
 			// Override to our own token helper
-			tokenHelper: tokenhelper.NewTestingTokenHelper(),
+			tokenHelper: token.NewTestingTokenHelper(),
 		},
 	}
 }

command/login_test.go

@@ -12,9 +12,9 @@ import (
 
 	"github.com/hashicorp/cli"
 	"github.com/hashicorp/vault/api"
-	"github.com/hashicorp/vault/api/tokenhelper"
 	credToken "github.com/hashicorp/vault/builtin/credential/token"
 	credUserpass "github.com/hashicorp/vault/builtin/credential/userpass"
+	"github.com/hashicorp/vault/command/token"
 	"github.com/hashicorp/vault/helper/testhelpers"
 	"github.com/hashicorp/vault/vault"
 )
@@ -33,7 +33,7 @@ func testLoginCommand(tb testing.TB) (*cli.MockUi, *LoginCommand) {
 			UI: ui,
 
 			// Override to our own token helper
-			tokenHelper: tokenhelper.NewTestingTokenHelper(),
+			tokenHelper: token.NewTestingTokenHelper(),
 		},
 		Handlers: map[string]LoginHandler{
 			"token":    &credToken.CLIHandler{},

command/token/helper_testing.go

@@ -0,0 +1,47 @@
+// Copyright (c) HashiCorp, Inc.
+// SPDX-License-Identifier: BUSL-1.1
+
+package token
+
+import (
+	"sync"
+
+	"github.com/hashicorp/vault/api/tokenhelper"
+)
+
+var _ tokenhelper.TokenHelper = (*TestingTokenHelper)(nil)
+
+// TestingTokenHelper implements token.TokenHelper which runs entirely
+// in-memory. This should not be used outside of testing.
+type TestingTokenHelper struct {
+	lock  sync.RWMutex
+	token string
+}
+
+func NewTestingTokenHelper() *TestingTokenHelper {
+	return &TestingTokenHelper{}
+}
+
+func (t *TestingTokenHelper) Erase() error {
+	t.lock.Lock()
+	defer t.lock.Unlock()
+	t.token = ""
+	return nil
+}
+
+func (t *TestingTokenHelper) Get() (string, error) {
+	t.lock.RLock()
+	defer t.lock.RUnlock()
+	return t.token, nil
+}
+
+func (t *TestingTokenHelper) Path() string {
+	return ""
+}
+
+func (t *TestingTokenHelper) Store(token string) error {
+	t.lock.Lock()
+	defer t.lock.Unlock()
+	t.token = token
+	return nil
+}