Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation message for allow_resource_tags_on_deletion in google_bigquery_table #18811

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11228.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:deprecation
bigquery: deprecated `allow_resource_tags_on_deletion` in `google_bigquery_table`.
```
3 changes: 2 additions & 1 deletion google/services/bigquery/resource_bigquery_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -1256,7 +1256,8 @@ func ResourceBigQueryTable() *schema.Resource {
Type: schema.TypeBool,
Optional: true,
Default: false,
Description: `Whether or not to allow table deletion when there are still resource tags attached.`,
Description: `**Deprecated** Whether or not to allow table deletion when there are still resource tags attached.`,
Deprecated: `This field is deprecated and will be removed in a future major release. The default behavior will be allowing the presence of resource tags on deletion after the next major release.`,
},

// TableConstraints: [Optional] Defines the primary key and foreign keys.
Expand Down
4 changes: 4 additions & 0 deletions website/docs/r/bigquery_table.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,10 @@ The following arguments are supported:
deletion when there are still resource tags attached. The default value is
false.

~>**Warning:** `allow_resource_tags_on_deletion` is deprecated and will be
removed in a future major release. The default behavior will be allowing
the presence of resource tags on deletion after the next major release.

<a name="nested_external_data_configuration"></a>The `external_data_configuration` block supports:

* `autodetect` - (Required) - Let BigQuery try to autodetect the schema
Expand Down