Add plural data source google_kms_crypto_keys
#18605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:f514cc2e5b57129f3136b17ce602aa724fa390c4] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
modular-magician
deleted the
downstream-pr-f514cc2e5b57129f3136b17ce602aa724fa390c4
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new plural data source
google_kms_crypto_keys.Note: a weird part of this work is the need to explicitly add the
idfield to the schema for each individual key. The alternative would be to update thegoogle_kms_crypto_keyresource to haveidin its schema (instead of implicitly added by the SDK) but this doesn't appear to be easily possible via MMv1.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11053