Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new service stack: API Center #28007

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
fbad8f8
Support for new service stack: API Center
favoretti Nov 14, 2024
e1cc6eb
make generate and typos
favoretti Nov 14, 2024
0057b5e
wip
favoretti Nov 20, 2024
cc77109
wip
favoretti Dec 4, 2024
de9910f
Added environment
favoretti Jan 22, 2025
2f5fc77
Add apicenter_service docs
favoretti Jan 22, 2025
db1e1af
fmt/generate
favoretti Jan 22, 2025
bf9720f
Add environment docs
favoretti Jan 22, 2025
8631ca8
Updated environment with parts of feedback
favoretti Jan 28, 2025
dedd77d
Update internal/services/apicenter/apicenter_environment_resource_tes…
favoretti Jan 28, 2025
74a35d6
Lint/fmt/generate
favoretti Jan 28, 2025
0dc9c9d
More feedback rework
favoretti Jan 29, 2025
1962bd5
Feedback rework
favoretti Jan 31, 2025
d311bc6
Typofix, test fix
favoretti Jan 31, 2025
a1135d1
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
ea026ef
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
ef2a4b4
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
30c1f7f
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
9d15c60
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
79e4d80
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
26e9c28
Update internal/services/apicenter/api_center_environment_resource.go
favoretti Feb 26, 2025
d5b7b85
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
9fe0a99
Fix casing
favoretti Feb 26, 2025
22f7424
Update internal/services/apicenter/api_center_service_resource.go
favoretti Feb 26, 2025
66dfc9e
Update internal/services/apicenter/api_center_environment_resource.go
favoretti Feb 26, 2025
a2e3c68
Update internal/services/apicenter/api_center_environment_resource.go
favoretti Feb 26, 2025
fca144a
Fix feedback
favoretti Feb 26, 2025
08b1d8b
Address feedback
favoretti Feb 26, 2025
dcda7c7
fmt
favoretti Feb 26, 2025
a15a3d3
Fix identity
favoretti Feb 26, 2025
99bf40c
Sort out property names
favoretti Feb 26, 2025
65a2b35
Fid property name in tests
favoretti Feb 26, 2025
4ff470a
Fix up tests
favoretti Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ service/analysis:
service/api-management:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_api_management((.|\n)*)###'

service/apicenter:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_api_center_((.|\n)*)###'

service/app-configuration:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_app_configuration((.|\n)*)###'

Expand Down
5 changes: 5 additions & 0 deletions .github/labeler-pull-request-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ service/api-management:
- any-glob-to-any-file:
- internal/services/apimanagement/**/*

service/apicenter:
- changed-files:
- any-glob-to-any-file:
- internal/services/apicenter/**/*

service/app-configuration:
- changed-files:
- any-glob-to-any-file:
Expand Down
1 change: 1 addition & 0 deletions .teamcity/components/generated/services.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ var services = mapOf(
"apimanagement" to "API Management",
"advisor" to "Advisor",
"analysisservices" to "Analysis Services",
"apicenter" to "ApiCenter",
"appconfiguration" to "App Configuration",
"appservice" to "AppService",
"applicationinsights" to "Application Insights",
Expand Down
3 changes: 3 additions & 0 deletions .teamcity/components/settings.kt
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ var serviceTestConfigurationOverrides = mapOf(
// Server is only available in certain locations
"analysisservices" to testConfiguration(locationOverride = LocationConfiguration("westus", "northeurope", "southcentralus", true)),

// API Center is only available in certain locations
"apicenter" to testConfiguration(locationOverride = LocationConfiguration("eastus", "australiaeast", "westeurope", true)),

// App Service Plans for Linux are currently unavailable in WestUS2
"appservice" to testConfiguration(startHour = 3, daysOfWeek = "2,4,6", locationOverride = LocationConfiguration("westeurope", "westus2", "eastus2", true)),

Expand Down
5 changes: 5 additions & 0 deletions internal/clients/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import (
aadb2c "github.com/hashicorp/terraform-provider-azurerm/internal/services/aadb2c/client"
advisor "github.com/hashicorp/terraform-provider-azurerm/internal/services/advisor/client"
analysisServices "github.com/hashicorp/terraform-provider-azurerm/internal/services/analysisservices/client"
apiCenter "github.com/hashicorp/terraform-provider-azurerm/internal/services/apicenter/client"
apiManagement "github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement/client"
appConfiguration "github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration/client"
applicationInsights "github.com/hashicorp/terraform-provider-azurerm/internal/services/applicationinsights/client"
Expand Down Expand Up @@ -161,6 +162,7 @@ type Client struct {
AadB2c *aadb2c_v2021_04_01_preview.Client
Advisor *advisor.Client
AnalysisServices *analysisservices_v2017_08_01.Client
ApiCenter *apiCenter.Client
ApiManagement *apiManagement.Client
AppConfiguration *appConfiguration.Client
AppInsights *applicationInsights.Client
Expand Down Expand Up @@ -309,6 +311,9 @@ func (client *Client) Build(ctx context.Context, o *common.ClientOptions) error
if client.AnalysisServices, err = analysisServices.NewClient(o); err != nil {
return fmt.Errorf("building clients for AnalysisServices: %+v", err)
}
if client.ApiCenter, err = apiCenter.NewClient(o); err != nil {
return fmt.Errorf("building clients for ApiCenter: %+v", err)
}
if client.ApiManagement, err = apiManagement.NewClient(o); err != nil {
return fmt.Errorf("building clients for ApiManagement: %+v", err)
}
Expand Down
3 changes: 3 additions & 0 deletions internal/provider/services.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"github.com/hashicorp/terraform-provider-azurerm/internal/services/aadb2c"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/advisor"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/analysisservices"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/apicenter"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration"
"github.com/hashicorp/terraform-provider-azurerm/internal/services/applicationinsights"
Expand Down Expand Up @@ -140,6 +141,7 @@ import (
func SupportedTypedServices() []sdk.TypedServiceRegistration {
services := []sdk.TypedServiceRegistration{
aadb2c.Registration{},
apicenter.Registration{},
apimanagement.Registration{},
appconfiguration.Registration{},
applicationinsights.Registration{},
Expand Down Expand Up @@ -239,6 +241,7 @@ func SupportedUntypedServices() []sdk.UntypedServiceRegistration {
out := []sdk.UntypedServiceRegistration{
advisor.Registration{},
analysisservices.Registration{},
apicenter.Registration{},
apimanagement.Registration{},
appconfiguration.Registration{},
applicationinsights.Registration{},
Expand Down
Loading
Loading