-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix azuread_privileged_access_group_eligibility_schedule resource update functionality #1614
base: main
Are you sure you want to change the base?
Conversation
Updating the Update functionality to use the adminUpdate: For administrators to change existing eligible assignments. instead of adminAssign: For administrators to assign group membership or ownership eligibility to principals. As per microsoft graph documentation
Any luck with merging the PR? |
I'm interested in this one too as I've hit the issue where you get 400 errors and are unable to apply after any changes are required. I need to manually delete all the assignments and reapply to make it work which given how slow the azure interface is for this is really painful. |
This is definitely the solution we are looking for; total pain in the rear without it at the moment having to recreate role assignments. |
An issue for us as well. Looking forward to a solution soon. |
PR is ready for review, folks are looking for review/merge status |
Issue that we are facing at the moment as well, hopefully will be looked at soon! |
bump! |
This seems like a simple fix, can anyone check out this PR please? @hashicorp-cloud |
I've been doing testing on this fix today. It looks like it causes a problem where the state is not being updated after the change is applied. I think its because when the update takes place a new assignment is created on the MS side but the state is not updated with this new assignment information and still has the original ID reference. So every time it reads from the API it uses the previous assignments ID which contains the original configuration so Terraform see's no changes being required. |
My goal with this pull request is to improve the azuread_privileged_access_group_eligibility_schedule resource.
Updating the 'Update' functionality to use the
adminUpdate
instead ofadminAssign
As per Microsoft graph documentationI found this issue in relation to this problem: #1412
As this is my first fork pull request, I hope this way is correct to do it. If not, please let me know so I can improve the pull request.