feature(invitations): remove retry on delete since it will be hamilto…

…n's responsability

internal/helpers/msgraph/replication.go

@@ -39,37 +39,6 @@ func WaitForCreationReplication(ctx context.Context, f func() (interface{}, int,
 	}).WaitForStateContext(ctx)
 }
 
-func WaitForDeletionReplication(ctx context.Context, f func() (interface{}, int, error)) (interface{}, error) {
-	deadline, ok := ctx.Deadline()
-	if !ok {
-		return nil, fmt.Errorf("context has no deadline")
-	}
-	timeout := time.Until(deadline)
-	return (&resource.StateChangeConf{
-		Pending:                   []string{"Found", "BadCast"},
-		Target:                    []string{"NotFound"},
-		Timeout:                   timeout,
-		MinTimeout:                1 * time.Second,
-		ContinuousTargetOccurence: 3,
-		Refresh: func() (interface{}, string, error) {
-			i, status, err := f()
-
-			switch {
-			case status >= 200 && status < 300:
-				return i, "Found", nil
-			case status == 404:
-				return i, "NotFound", nil
-			case i == nil:
-				return nil, "BadCast", nil
-			case err != nil:
-				return i, "Error", fmt.Errorf("unable to retrieve object, received response with status %d: %v", status, err)
-			}
-
-			return i, "Error", fmt.Errorf("unrecognised response with status %d", status)
-		},
-	}).WaitForStateContext(ctx)
-}
-
 func WaitForListAdd(ctx context.Context, item string, f func() ([]string, error)) (interface{}, error) {
 	deadline, ok := ctx.Deadline()
 	if !ok {

internal/services/invitations/invitation_resource_msgraph.go

@@ -117,15 +117,6 @@ func invitationResourceDeleteMsGraph(ctx context.Context, d *schema.ResourceData
 		return tf.ErrorDiagPathF(err, "id", "Deleting user with object ID %q, got status %d", userID, status)
 	}
 
-	_, err = helpers.WaitForDeletionReplication(ctx, func() (interface{}, int, error) {
-		userClient := meta.(*clients.Client).Users.MsClient
-		return userClient.Get(ctx, userID)
-	})
-
-	if err != nil {
-		return tf.ErrorDiagF(err, "Waiting for deletion of User with object ID: %q", userID)
-	}
-
 	return nil
 }