Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f/aws_rds_cluster-add-enhanced-monitoring #41002

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dansyuqri
Copy link
Contributor

Description

This PR adds the monitoring_interval and monitoring_role_arn input parameters to the aws_rds_cluster resource. This allows enhanced monitoring to be set at the RDS Cluster level.

Relations

Closes #40966

References

See --monitoring-interval and --monitoring-role-arn
https://docs.aws.amazon.com/cli/latest/reference/rds/modify-db-cluster.html#options

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_enabledToDisabled PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_enabledToDisabled'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToDisabled
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToDisabled (1720.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1724.393s

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== PAUSE TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
=== CONT  TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval
--- PASS: TestAccRDSCluster_enhancedMonitoring_enabledToUpdatedMonitoringInterval (1643.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1647.481s

% make testacc TESTS=TestAccRDSCluster_enhancedMonitoring_disabledToEnabled PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_enhancedMonitoring_disabledToEnabled'  -timeout 360m
=== RUN   TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== PAUSE TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
=== CONT  TestAccRDSCluster_enhancedMonitoring_disabledToEnabled
--- PASS: TestAccRDSCluster_enhancedMonitoring_disabledToEnabled (1437.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        1445.990s

@Dansyuqri Dansyuqri requested a review from a team as a code owner January 20, 2025 00:03
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Jan 20, 2025
@Dansyuqri Dansyuqri force-pushed the f-aws_rds_cluster-add-enhanced-monitoring branch from b0fefdb to 72dd639 Compare January 20, 2025 02:06
@Dansyuqri Dansyuqri force-pushed the f-aws_rds_cluster-add-enhanced-monitoring branch from 72dd639 to 3e64064 Compare January 20, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Set monitoring interval for RDS clusters
1 participant