Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fixes to reattach testing. #553

Merged
merged 7 commits into from
Sep 4, 2020

Conversation

paddycarver
Copy link
Contributor

Backport including step number in error messages, backport fix to use correct state when conducting import tests, and backport better diffs in error messages.

This backports #552, #526, and #524.

Backport including step number in error messages, and backport fix to
use correct state when conducting import tests.
@paddycarver paddycarver requested a review from a team August 26, 2020 05:12
When trying to find the resource state when verifying imports, take the
resource's provider into consideration.

This is a backport of #522.
@paddycarver
Copy link
Contributor Author

Backported #522 as well.

Stop extra logging when a non-empty plan is expected and received.
Ignore data sources when verifying imported state.
Fixed import state testing to be able to return an error that
TestStep.ExpectError can handle.
Fixes testStepNewConfig to always return errors instead of calling
t.Fatal, so we can output the step numbers that failed.
This fixes binary testing to take TestStep.Destroy into account, and
cleans up several other discrepancies between the test framework's
behavior under binary testing and legacy testing.
@paddycarver
Copy link
Contributor Author

I pushed new commits backporting #556, #555, #550, #557, and #563, which I believe brings this inline with all the bug fixes on master.

If the code looks good, I'll merge it, and @mbfrahry has volunteered to run some tests against it, then we can cut a release.

@paddycarver paddycarver merged commit d6c8d66 into v1-maint Sep 4, 2020
@paddycarver paddycarver deleted the paddy_finish_reattach_backport branch September 4, 2020 18:12
@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants