-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript support. Closes #1025 #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was finally able to give this a proper read. It looks good to me and I'm all for the functionality— thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice with better typescript integration, but I'm concerned about officially supporting it. The main issue is that the transpiling can introduce extra checks in the output, some of which can be impossible to reach using tests, causing coverage to fall. I don't know if there is a reasonable solution to this?
I would also like to see a test for how --typescript
behaves when the dependency is missing, similar to
Line 1967 in 6533396
it('runs when typescript fails to load', async () => { |
We need to move to use v8 built-in coverage tooling to get proper coverage reports and get rid of the way we do it today. That said, it works pretty well. I haven't hit any actual issues with coverage so far. The additional code is pretty small and supporting it would be trivial. If limitations are found in the future, we can deal with them then or move support elsewhere as last resort. |
No need since this is only in the cli, not the reporter so it will just fail as expected. |
I'm talking the coverage tool when applied to |
No description provided.