4.0.6 candidate #1270
Merged
4.0.6 candidate #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are run through the transpiler and just reverting the user of template literal is easier than adding transpiler to the test stack.
lawnsea: this contains the changes from 8a9c79b
This was causing a difficult to diagnose failure under IE and doesn’t give us enough value to justify the change.
To preserve license info in Closure Compiler the license has to be JSDoc-comment (not simple comment) and have @license before license text
Add a new package [just-handlebars-helpers](/~https://github.com/leapfrogtechnology/just-handlebars-helpers) on the list. This is a lightweight package that offers a collection of common handlebars helpers. And it is [fully tested](https://codecov.io/github/leapfrogtechnology/just-handlebars-helpers)
The root cause of handlebars-lang#1218 is that `invokePartial` creates a stack of data frames for nested partial blocks, but `resolvePartial` always uses the value at top of the stack without "popping" it. The result is an infinite recursive loop, as references to `@partial-block` in the partial at the top of the stack resolve to itself. So, walk up the stack of data frames when evaluating. This is accomplished by 1) setting the `partial-block` property to `noop` after use and 2) using `_parent['partial-block']` if `partial-block` is `noop` Fix handlebars-lang#1218
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1256 by releasing all changes on master that can ship in a patch release. I've included only bug fixes, non-breaking tooling changes, and documentation updates.
One commit of note that I did not include was 768ddbd, which is a bug fix, but changes undocumented behavior of the custom helper API. I think it should ship in the next major release.
Note that this PR must not be squashed when landed to the 4.x branch.