Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vidisha.hackclub.com #1490

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Adding vidisha.hackclub.com #1490

merged 7 commits into from
Jan 13, 2025

Conversation

arjav0703
Copy link
Contributor

add hackclub Vidisha's website

src: /~https://github.com/arjav0703/hackclub-vidisha

add hackvlub Vidisha's website
@arjav0703 arjav0703 requested review from a team as code owners January 10, 2025 16:09
Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sort alphabetically within the file

Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert extraneous change

@@ -3343,3 +3347,4 @@ metabase:
- ttl: 600
type: CNAME
value: a.selfhosted.hackclub.com.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I supposed to add a '-' at line 3350 ?

Copy link
Member

@alx-alexpark alx-alexpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@arjav0703
Copy link
Contributor Author

Thanks ! can I get instructions on how to implement this with github pages. Repo: /~https://github.com/arjav0703/hackclub-vidisha

@alx-alexpark alx-alexpark merged commit 30dd654 into hackclub:main Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants