Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Neutrino V6 #4

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Conversation

soulchainer
Copy link
Collaborator

Just that. Version 6 came out a few days ago and I'm using this preset, so need it updated ^^.

The small change in index.js, in case you ask, it's because of a breaking change described here:

BREAKING CHANGE An empty object is no longer passed as options to middleware if no options have been specified.

Without that, it doesn't work and, obviously, tests doesn't pass.

I also updated the rest of packages «properly». eslint doesn't jump to 4.0.0 because Neutrino still don't support it.

As in previous times, I didn't bumped the version in package.json, neither updated the CHANGELOG.md. I'm kinda bad with that, and it's not my project, so try to not screw it over xD.

Copy link
Owner

@guzart guzart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@guzart guzart merged commit 4d48679 into guzart:master Aug 16, 2017
@soulchainer
Copy link
Collaborator Author

Yaaaay! :D.

Anyways, @guzart: in the releases title and etcétera, you have a typo. It's V6, not V5 ;).

@guzart
Copy link
Owner

guzart commented Aug 16, 2017

Hehe... my eyes are not working properly today... 😳 . Thanks, will fix.

@soulchainer soulchainer deleted the update_to_Neutrino_V6 branch August 16, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants