option to not clone buffer #16

gulpjs · Sep 27, 2016 · 2f45470 · 2f45470
1 parent 1da7b3c
commit 2f45470
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -46,11 +46,12 @@ File.prototype.isDirectory = function() {
 
 File.prototype.clone = function(opt) {
   if (typeof opt === 'boolean') {
-    opt = { deep: opt };
+    opt = { deep: opt, contents: true };
   } else if (!opt) {
-    opt = { deep: false };
+    opt = { deep: false, contents: true };
   } else {
-    opt.deep = opt.deep || false;
+    opt.deep = opt.deep === true;
+    opt.contents = opt.contents !== false;
   }
 
   var clone = new File();
@@ -61,7 +62,7 @@ File.prototype.clone = function(opt) {
     }
   }, this);
 
-  clone.contents = this.isBuffer() ? cloneBuffer(this.contents) : this.contents;
+  clone.contents = opt.contents && this.isBuffer() ? cloneBuffer(this.contents) : this.contents;
   clone.stat = this.stat ? cloneStats(this.stat) : null;
 
   return clone;

diff --git a/test/File.js b/test/File.js
@@ -196,6 +196,28 @@ describe('File', function() {
       done();
     });
 
+    it('should copy buffer\'s reference with option contents: false', function(done) {
+      var options = {
+        cwd: '/',
+        base: '/test/',
+        path: '/test/test.js',
+        contents: new Buffer('test')
+      };
+
+      var file = new File(options);
+
+      var copy1 = file.clone({ contents: false });
+      copy1.contents.should.equal(file.contents);
+
+      var copy2 = file.clone({});
+      copy2.contents.should.not.equal(file.contents);
+
+      var copy3 = file.clone({ contents: 'any string' });
+      copy3.contents.should.not.equal(file.contents);
+
+      done();
+    });
+
     it('should copy all attributes over with Stream', function(done) {
       var options = {
         cwd: '/',