Deignoring #319
Deignoring #319
Conversation
|
Great, thanks! cc @gkoz |
| } | ||
| } | ||
|
|
||
| //pub fn get_display(&self) -> /*Ignored*/Option<gdk::Display> { |
There was a problem hiding this comment.
Looks like we should add Gdk.Display to the list of manual objects.
|
Updated |
|
@gkoz If you merge gtk-rs/gir#248 first, I update this |
| @@ -6,7 +6,7 @@ GIR_FILES = gir-files/Gtk-3.0.gir | |||
| gir : src/auto/mod.rs | |||
|
|
|||
| src/auto/mod.rs : Gir.toml $(GIR) $(GIR_FILES) | |||
| $(GIR) -c Gir.toml | |||
| $(GIR) -c Gir.toml -s | |||
There was a problem hiding this comment.
Oh, you meant adding to the makefile. Well, it doesn't seem like something useful in a regular workflow. Isn't the run time in single digits for you now?
There was a problem hiding this comment.
IMHO this way is better defended from sudden time regression.
There was a problem hiding this comment.
It doesn't appear in any automation. Locally a sudden slowdown should be easy enough to notice.
There was a problem hiding this comment.
Only sys generation builds automatic, stats unneeded here.
|
Done |
| impl Clipboard { | ||
| pub fn set_text(&self, text: &str) { | ||
| unsafe { | ||
| ffi::gtk_clipboard_set_text(self.to_glib_none().0, text.to_glib_none().0, text.len() as i32); |
There was a problem hiding this comment.
Since we're passing the length, CString conversion can be avoided, like in text_buffer.
|
Fixed. Also separate wrong union of Regen and manual |
EPashkin
force-pushed
the
deignoring
branch
2 times, most recently
from
45234e3 to
d81647f
Compare
|
Fixed again: using |
|
@gkoz, restart AppVeyor please, it has clone error, or merge PR |
|
Appveyor restarted. |
|
AppVeyor build succeeded |
| } | ||
| } | ||
|
|
||
| //pub fn get_current_device_grab(&self, device: /*Ignored*/&gdk::Device) -> Option<Widget> { |
There was a problem hiding this comment.
Looks like we've missed the need for Gdk.Device
|
Fixed all |
|
AppVeyor build succeeded |
|
Adding final part of |
|
Again forgot build examples with latest gtk :( |
|
Restarted. |
|
Everything looks good now. Thanks @EPashkin |
…reference_in_enum Remove unused uses in generated enums.rs
No description provided.