Skip to content

Commit

Permalink
missed a few places
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiitk committed Nov 1, 2023
1 parent 883fb0e commit 81045dd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import io.grpc.ClientCall;
import io.grpc.ConnectivityState;
import io.grpc.ExperimentalApi;
import io.grpc.ForwardingChannelBuilder;
import io.grpc.ForwardingChannelBuilder2;
import io.grpc.InternalManagedChannelProvider;
import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
Expand All @@ -53,7 +53,7 @@
*
* @since 1.12.0
*/
public final class AndroidChannelBuilder extends ForwardingChannelBuilder<AndroidChannelBuilder> {
public final class AndroidChannelBuilder extends ForwardingChannelBuilder2<AndroidChannelBuilder> {

private static final String LOG_TAG = "AndroidChannelBuilder";

Expand Down
5 changes: 2 additions & 3 deletions binder/src/main/java/io/grpc/binder/BinderChannelBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import io.grpc.ChannelCredentials;
import io.grpc.ChannelLogger;
import io.grpc.ExperimentalApi;
import io.grpc.ForwardingChannelBuilder;
import io.grpc.ForwardingChannelBuilder2;
import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
import io.grpc.binder.internal.BinderTransport;
Expand All @@ -51,8 +51,7 @@
* Services</a>
*/
@ExperimentalApi("/~https://github.com/grpc/grpc-java/issues/8022")
public final class BinderChannelBuilder
extends ForwardingChannelBuilder<BinderChannelBuilder> {
public final class BinderChannelBuilder extends ForwardingChannelBuilder2<BinderChannelBuilder> {

/**
* Creates a channel builder that will bind to a remote Android service.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ public static Collection<Object[]> params() throws Exception {
classes.add(new Object[]{clazz});
continue;
}
// ForwardingChannelBuilder extends ForwardingChannelBuilder2, not need for extra checks.
if (ManagedChannelBuilder.class.isAssignableFrom(clazz)
&& clazz != ManagedChannelBuilder.class && clazz != ForwardingChannelBuilder.class) {
&& clazz != ManagedChannelBuilder.class && clazz != ForwardingChannelBuilder2.class) {
classes.add(new Object[]{clazz});
}
}
Expand Down

0 comments on commit 81045dd

Please sign in to comment.