Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made GenericQuadrature general to accept AbstractVectors #839

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Made GenericQuadrature general to accept AbstractVectors #839

merged 2 commits into from
Oct 18, 2022

Conversation

kishore-nori
Copy link
Collaborator

  • This is particularly useful to pass weights of quadratures as FillArrays
  • Very useful in DiracDelta quadrature setup and also to write something like Monte Carlo quadrature
  • Related testing mechanism has been modified accordingly and a test has been added
  • Already used now in the DiracDelta for generic points

@kishore-nori kishore-nori self-assigned this Oct 17, 2022
@amartinhuertas
Copy link
Member

Thanks for the pr. Can you please add an entry to the news.md file ?

@kishore-nori
Copy link
Collaborator Author

Hi Alberto, thank you for taking a look, I updated the NEWS.md..

@amartinhuertas amartinhuertas merged commit a8b490d into master Oct 18, 2022
@kishore-nori kishore-nori deleted the generic-quadrature branch October 18, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amartinhuertas amartinhuertas amartinhuertas left review comments

Assignees

@kishore-nori kishore-nori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore-nori @amartinhuertas