Extract Kerberos functionality from SQL Server engine #51352
+397
−328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tener
added
the
no-changelog
github-actions
bot
added
database-access
greedy52
approved these changes
Jan 22, 2025
greedy52
reviewed
Jan 22, 2025
|
|
||
| type clientProvider struct { | ||
| AuthClient windows.AuthInterface | ||
| DataDir string |
There was a problem hiding this comment.
We had some offline discussion on the cache dir. we can look into that afterwards. Here are just some notes but they should not block this PR:
kinit does refresh the output every connection, but there could be a race that two connections trying to output to the same file then read it.
On the other hand, it seems credentials.LoadCCache finishes reading that file immediately and has no use of it afterwards. We could experiment if we could just use tmp dir instead of data-dir.
Another consideration is if we want to add real caching to avoid kinit on every connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
kinitintodb/commonkerberos.ClientProvider.kerberos.ClientProviderI've tried very hard to keep this change minimal. There is a number of things I'd like to change in the current code, but those changes can happen in future PRs while keeping this one as small as possible.
This is a prerequisite to using Kerberos in other db engines, in particular Oracle.