Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Add polyfill for crypto.randomUUID #26368

Merged
merged 1 commit into from
May 19, 2023
Merged

[Web] Add polyfill for crypto.randomUUID #26368

merged 1 commit into from
May 19, 2023

Conversation

rudream
Copy link
Contributor

@rudream rudream commented May 16, 2023 •
edited
Loading

e counterpart: /~https://github.com/gravitational/teleport.e/pull/1422

Purpose

Adds a polyfill fallback for crypto.randomUUID for old browsers that don't support it.

Polyfill is from /~https://github.com/uuidjs/randomUUID

Tested with Firefox 91.0

@rudream rudream changed the title [Web [Web] Add polyfill for crypto.randomUUID May 16, 2023
@github-actions github-actions bot requested review from gzdunek and ryanclark May 16, 2023 16:32
@rudream rudream requested review from ravicious, zmb3 and kimlisa May 16, 2023 16:35
@rudream rudream force-pushed the yassine/randomuuid branch 2 times, most recently from 6ec9594 to 896ef35 Compare May 16, 2023 16:50
@rudream rudream requested a review from ravicious May 17, 2023 14:06
avatus
avatus approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preemptive approve once the few questions have been answered. neat stuff!

ravicious
ravicious approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for researching that question about the secure context.

Should we backport this all the way to v11 if needed?

web/packages/teleport/src/lib/polyfillRandomUuid.js Show resolved Hide resolved
web/packages/shared/components/Notification/Notification.story.tsx Show resolved Hide resolved
@rudream rudream force-pushed the yassine/randomuuid branch from d375138 to dc14f55 Compare May 19, 2023 14:51
@rudream rudream enabled auto-merge May 19, 2023 14:51
@rudream rudream added this pull request to the merge queue May 19, 2023
Merged via the queue into master with commit c9b3803 May 19, 2023
@rudream rudream deleted the yassine/randomuuid branch May 19, 2023 15:17
@public-teleport-github-review-bot
Copy link

@rudream See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

This was referenced May 19, 2023
Merged
Merged
rudream added a commit that referenced this pull request May 19, 2023
@rudream
add polyfill for randomuuid (#26368)
77355c3
@rudream rudream mentioned this pull request May 19, 2023
Merged
rudream added a commit that referenced this pull request May 25, 2023
@rudream
add polyfill for randomuuid (#26368)
d0bab64
ptgott pushed a commit that referenced this pull request May 25, 2023
@rudream
add polyfill for randomuuid (#26368) (#26617)
20fb6bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avatus avatus avatus approved these changes

@ravicious ravicious ravicious approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 size/md ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudream @ravicious @avatus