Fix TestKeyboardPress test panic
#1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
previously approved these changes
Nov 7, 2024
inancgumus
force-pushed
the
fix/sobek-ptr-any-slice-parsing
branch
from
104780f to
19b6407
Compare
inancgumus
requested review from
olegbespalov and
joanlopez
and removed request for
a team
This only fixes the panic, but not the underlying error with WaitForEvent. There is clearly an issue with WaitForEvent as we can also see in #1506.
inancgumus
force-pushed
the
fix/test-keyboard-press-test-panic
branch
from
dd098ed to
17a865f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix
TestKeyboardPresstest panic.Why?
This only fixes the panic but not the underlying error with
WaitForEvent. As we can also see in #1506, there is clearly an issue withWaitForEvent.Note
This fix highlights the fact that we should use
requireinstead ofassertwhen an error should block the test from continuing.Checklist
Related PR(s)/Issue(s)
Updates #1505