Use mergeWith parseBrowserContextOptions

grafana · Nov 6, 2024 · eea70f6 · eea70f6
1 parent f1f03ee
commit eea70f6
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/browser/browser_mapping.go b/browser/browser_mapping.go
@@ -110,11 +110,8 @@ func initBrowserContext(bctx *common.BrowserContext, testRunID string) error {
 
 // parseBrowserContextOptions parses the [common.BrowserContext] options from a Sobek value.
 func parseBrowserContextOptions(rt *sobek.Runtime, opts sobek.Value) (*common.BrowserContextOptions, error) {
-	if !sobekValueExists(opts) {
-		return nil, nil //nolint:nilnil
-	}
 	b := common.NewBrowserContextOptions()
-	if err := rt.ExportTo(opts, &b); err != nil {
+	if err := mergeWith(rt, b, opts); err != nil {
 		return nil, fmt.Errorf("parsing browser context options: %w", err)
 	}
 	return b, nil