Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Add more details to HTTP Outgoing Request #664

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

xnyo
Copy link
Member

@xnyo xnyo commented Mar 30, 2023

What this PR does / why we need it:

Adds otelhttptrace to the httpclient TracingMiddleware.

Matches the behaviour added by this PR in core: grafana/grafana#64757

Which issue(s) this PR fixes:

Fixes #655

Special notes for your reviewer:

@xnyo xnyo added enhancement New feature or request go Pull requests that update Go code labels Mar 30, 2023
@xnyo xnyo self-assigned this Mar 30, 2023
@xnyo xnyo changed the title Tracing: Add more detail to HTTP Outgoing Request Tracing: Add more details to HTTP Outgoing Request Apr 5, 2023
@xnyo xnyo marked this pull request as ready for review April 5, 2023 08:26
@xnyo xnyo requested a review from a team as a code owner April 5, 2023 08:26
@xnyo xnyo requested review from marefr and andresmgot and removed request for a team April 5, 2023 08:26
Copy link
Contributor

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@xnyo xnyo merged commit e675b59 into main Apr 5, 2023
@xnyo xnyo deleted the giuseppe/tracing-otelhttptrace branch April 5, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
Development

Successfully merging this pull request may close these issues.

Tracing: Add more details to outgoing HTTP requests
2 participants