Camilos fixes #457
Closed
Camilos fixes #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is based on #446. That was ready to be merged anyways, @ehhartmann , right? |
|
Not ready, yet |
KRiedmiller
reviewed
Aug 23, 2024
| for recipe in recipe_collection.recipes: | ||
| dt = [x[1] - x[0] for x in recipe.timespans] | ||
| reaction_probability.append(sum(np.multiply(dt, recipe.rates))) | ||
| t_interval = recipe.timespans[-1][-1] - recipe.timespans[0][0] |
There was a problem hiding this comment.
This calculates the time between the first time this recipe becomes valid, and the last time it is valid. However, in between it might be invalid.
If the reaction probability should be scaled down by the time it should be ?
sum(dt)
|
already integrated via other PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-dump {time} in utils.py